From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 76C851B62C for ; Mon, 23 Oct 2017 16:34:39 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Oct 2017 07:34:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,423,1503385200"; d="scan'208";a="1208986893" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by fmsmga001.fm.intel.com with ESMTP; 23 Oct 2017 07:34:37 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.167]) by IRSMSX104.ger.corp.intel.com ([163.33.3.159]) with mapi id 14.03.0319.002; Mon, 23 Oct 2017 15:34:36 +0100 From: "De Lara Guarch, Pablo" To: "Tan, Jianfeng" , "dev@dpdk.org" CC: "jblunck@infradead.org" , "Richardson, Bruce" , "Ananyev, Konstantin" , "thomas@monjalon.net" , "yliu@fridaylinux.org" , "maxime.coquelin@redhat.com" , "mtetsuyah@gmail.com" , "Yigit, Ferruh" Thread-Topic: [PATCH v7 3/4] bus/vdev: move to vdev bus to drivers/bus Thread-Index: AQHTRBmBHn1An3OL1kSyHAdmD4E6+6LxjRXA Date: Mon, 23 Oct 2017 14:34:35 +0000 Message-ID: References: <1507519229-80692-1-git-send-email-jianfeng.tan@intel.com> <1507895521-48299-1-git-send-email-jianfeng.tan@intel.com> <1507895521-48299-4-git-send-email-jianfeng.tan@intel.com> In-Reply-To: <1507895521-48299-4-git-send-email-jianfeng.tan@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTQ2MmNlYWEtZjgzMC00ZmVlLTg1YTYtYWM3N2I5OTY5OTRkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IkhHTlpWVXhqcEZYdWVrdkVyNHdjXC9JV20yeFg5ckVxSEswamo1cDdVditvPSJ9 x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v7 3/4] bus/vdev: move to vdev bus to drivers/bus X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Oct 2017 14:34:39 -0000 Hi Jianfeng, > -----Original Message----- > From: Tan, Jianfeng > Sent: Friday, October 13, 2017 12:52 PM > To: dev@dpdk.org > Cc: jblunck@infradead.org; Richardson, Bruce > ; Ananyev, Konstantin > ; De Lara Guarch, Pablo > ; thomas@monjalon.net; > yliu@fridaylinux.org; maxime.coquelin@redhat.com; > mtetsuyah@gmail.com; Yigit, Ferruh ; Tan, > Jianfeng > Subject: [PATCH v7 3/4] bus/vdev: move to vdev bus to drivers/bus >=20 > Move the vdev bus from lib/librte_eal to drivers/bus. >=20 > As the crypto vdev helper function refers to data structure in rte_vdev.h= , so > we move those helper function into drivers/bus too. I am seeing some errors with this patch, compiling the test app: test/test/test_eventdev.c:54:10: error: implicit declaration of function 'r= te_vdev_init' [-Werror=3Dimplicit-function-declaration] return rte_vdev_init("event_skeleton", NULL); ^~~~~~~~~~~~~ test/test/test_eventdev.c:54:3: error: nested extern declaration of 'rte_vd= ev_init' [-Werror=3Dnested-externs] return rte_vdev_init("event_skeleton", NULL); ^~~~~~ Also, I have a couple of comments more below. ... > +++ b/drivers/bus/vdev/rte_bus_vdev_version.map > @@ -0,0 +1,8 @@ > +DPDK_17.11 { > + global: > + > + rte_vdev_init; > + rte_vdev_register; > + rte_vdev_uninit; > + rte_vdev_unregister; These functions should be removed from rte_eal_version.map, for Linux and BSD, right? Also, should this be documented in release notes?