From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: Ophir Munk <ophirmu@mellanox.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>
Cc: Gaetan Rivet <gaetan.rivet@6wind.com>,
"Ophir Munk <ophirmu@mellanox.com" <Ophir Munk
<ophirmu@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org>,
"Thomas Monjalon" <thomas@monjalon.net>,
Olga Shern <olgas@mellanox.com>,
"stable@dpdk.org" <stable@dpdk.org>,
Raslan Darawsheh <rasland@mellanox.com>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] app/testpmd: fix forwarding between non consecutive ports
Date: Tue, 7 Nov 2017 17:43:16 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8976CC45FC1@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <1510062750-29091-1-git-send-email-ophirmu@mellanox.com>
> -----Original Message-----
> From: stable [mailto:stable-bounces@dpdk.org] On Behalf Of Ophir Munk
> Sent: Tuesday, November 7, 2017 1:53 PM
> To: Wu, Jingjing <jingjing.wu@intel.com>
> Cc: Gaetan Rivet <gaetan.rivet@6wind.com>; Ophir Munk
> <ophirmu@mellanox.com; dev@dpdk.org; Thomas Monjalon
> <thomas@monjalon.net>; Olga Shern <olgas@mellanox.com>;
> stable@dpdk.org; Raslan Darawsheh <rasland@mellanox.com>
> Subject: [dpdk-stable] [PATCH v2] app/testpmd: fix forwarding between
> non consecutive ports
>
> When defining two failsafe devices in testpmd the port numbers of the
> failsafe devices may not be consecutive.
> For example: if failsafe device includes a PCI device and a TAP device then
> failsafe port numbers would be 0 and 3.
> Port 0 - failsafe #1 device
> Port 1 - PCI #1 device
> Port 2 - TAP #1 device
> Port 3 - failsafe #2 device
> Port 4 - PCI #2 device
> Port 5 - TAP #2 device
>
> If forwarding is defined between the failsafe devices including a peer
> address the forwarding should be between peer addresses of ports 0 and 3.
> Instead testpmd establishes forwarding between peer addresses of
> consecutive ports 0 and 1. This commit fixes this bug.
>
> Fixes: af75078fece3 ("first public release")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ophir Munk <ophirmu@mellanox.com>
> Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
next prev parent reply other threads:[~2017-11-07 17:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-06 14:19 [dpdk-dev] [PATCH v1] app/testpmd: fix fwd between two failsafe devices Ophir Munk
2017-11-07 13:31 ` [dpdk-dev] [PATCH v2] app/testpmd: fix forwarding between non consecutive ports Ophir Munk
2017-11-07 13:47 ` Ophir Munk
2017-11-07 13:52 ` Ophir Munk
2017-11-07 14:26 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2017-11-07 17:43 ` De Lara Guarch, Pablo [this message]
2017-11-07 20:42 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8976CC45FC1@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=gaetan.rivet@6wind.com \
--cc=jingjing.wu@intel.com \
--cc=ophirmu@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).