From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id B4245107A for ; Mon, 11 Dec 2017 14:39:16 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Dec 2017 05:39:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,391,1508828400"; d="scan'208";a="1631969" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by fmsmga008.fm.intel.com with ESMTP; 11 Dec 2017 05:39:14 -0800 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.167]) by IRSMSX107.ger.corp.intel.com ([169.254.10.239]) with mapi id 14.03.0319.002; Mon, 11 Dec 2017 13:39:12 +0000 From: "De Lara Guarch, Pablo" To: Ravi Kumar , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 01/11] cryptodev: add compile support for AMD CCP crypto PMD Thread-Index: AQHTad1iKSyabLzkYUOw6UJv7uRUN6M+NNxw Date: Mon, 11 Dec 2017 13:39:11 +0000 Message-ID: References: <1512047553-118101-1-git-send-email-Ravi1.kumar@amd.com> In-Reply-To: <1512047553-118101-1-git-send-email-Ravi1.kumar@amd.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiY2Q4NGU0YWMtMzEwYi00MjRkLTllNjAtYTU1ZGNiOTljZDAwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6ImRhOXl4akdEb2ExUTNmbTZDWDMyandhYWNwVTNqTXVxbEl5eXp1ZlRoaG89In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 01/11] cryptodev: add compile support for AMD CCP crypto PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Dec 2017 13:39:17 -0000 Hi Ravi, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ravi Kumar > Sent: Thursday, November 30, 2017 1:12 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH 01/11] cryptodev: add compile support for > AMD CCP crypto PMD >=20 Thanks for splitting the original patch into multiple ones. However, in this case, this should get merged to the other patches, as all the changes are referencing files/folders that do not exist yet. Apart from this, two comments below. Thanks, Pablo > Signed-off-by: Ravi Kumar > --- > MAINTAINERS | 6 ++++++ > config/common_base | 5 +++++ > drivers/crypto/Makefile | 1 + > mk/rte.app.mk | 2 ++ > 4 files changed, 14 insertions(+) >=20 > diff --git a/MAINTAINERS b/MAINTAINERS > index f0baeb4..daac82e 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -588,6 +588,12 @@ M: Pablo de Lara > > T: git://dpdk.org/next/dpdk-next-crypto > F: doc/guides/cryptodevs/features/default.ini >=20 > +AMD CCP Crypto PMD Remove trailing whitespace here. > +M: Ravi Kumar > +F: drivers/crypto/ccp/ > +F: doc/guides/cryptodevs/ccp.rst > +F: doc/guides/cryptodevs/features/ccp.ini Add these lines, as you add the files. > +