From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 42068567E; Mon, 11 Dec 2017 14:54:26 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Dec 2017 05:54:23 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,391,1508828400"; d="scan'208";a="1870377" Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23]) by orsmga008.jf.intel.com with ESMTP; 11 Dec 2017 05:54:23 -0800 Received: from irsmsx156.ger.corp.intel.com (10.108.20.68) by IRSMSX109.ger.corp.intel.com (163.33.3.23) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 11 Dec 2017 13:54:22 +0000 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.167]) by IRSMSX156.ger.corp.intel.com ([169.254.3.33]) with mapi id 14.03.0319.002; Mon, 11 Dec 2017 13:54:22 +0000 From: "De Lara Guarch, Pablo" To: Nelio Laranjeiro CC: Akhil Goyal , "Doherty, Declan" , "dev@dpdk.org" , Gaetan Rivet , "stable@dpdk.org" Thread-Topic: [PATCH v2 2/3] crypto: fix pedantic compilation errors Thread-Index: AQHTZEJQtOr7evlXd0OhLRkydMmQM6M+ImwAgAAQKYCAABNicA== Date: Mon, 11 Dec 2017 13:54:22 +0000 Message-ID: References: <1c3b73f0912ad4b3da8423590dc76fc83df16b80.1511338151.git.nelio.laranjeiro@6wind.com> <20171211124249.xti6cebljmllzygb@laranjeiro-vm.dev.6wind.com> In-Reply-To: <20171211124249.xti6cebljmllzygb@laranjeiro-vm.dev.6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTAxNzhmMTAtMGMwZS00N2NiLWJiZWQtMTA0ZmNkYjBjZWZjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6ImNCcnhGcXp6OE91ekF0SW9mZkJudGtyK1BVdzRtU3VsamtLbmE4VXdvQUU9In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 2/3] crypto: fix pedantic compilation errors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Dec 2017 13:54:28 -0000 > -----Original Message----- > From: Nelio Laranjeiro [mailto:nelio.laranjeiro@6wind.com] > Sent: Monday, December 11, 2017 12:43 PM > To: De Lara Guarch, Pablo > Cc: Akhil Goyal ; Doherty, Declan > ; dev@dpdk.org; Gaetan Rivet > ; stable@dpdk.org > Subject: Re: [PATCH v2 2/3] crypto: fix pedantic compilation errors >=20 > Hi Pablo, >=20 > On Mon, Dec 11, 2017 at 11:49:39AM +0000, De Lara Guarch, Pablo wrote: > > > > > > > -----Original Message----- > > > From: Nelio Laranjeiro [mailto:nelio.laranjeiro@6wind.com] > > > Sent: Thursday, November 23, 2017 10:03 AM > > > To: Akhil Goyal ; Doherty, Declan > > > > > > Cc: dev@dpdk.org; Gaetan Rivet ; De Lara > > > Guarch, Pablo ; stable@dpdk.org > > > Subject: [PATCH v2 2/3] crypto: fix pedantic compilation errors > > > > > > > ... > > > > > --- a/lib/librte_cryptodev/rte_crypto.h > > > +++ b/lib/librte_cryptodev/rte_crypto.h > > > @@ -121,7 +121,7 @@ struct rte_crypto_op { > > > rte_iova_t phys_addr; > > > /**< physical address of crypto operation */ > > > > > > - RTE_STD_C11 > > > + __extension__ > > > > Hi Nelio, > > > > Since RTE_STD_C11 is basically __extension__ when __STDC_VERSION__ > is > > not defined, Is this forcing __extension__ to be used no matter what? > (even if C11 is not supported). >=20 > Yes >=20 Right, and are we sure that this is OK? If C11 is supported, do we still wa= nt extension? Thanks, Pablo > Thanks, >=20 > -- > N=E9lio Laranjeiro > 6WIND