From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pablo.de.lara.guarch@intel.com> Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 2C83229CF for <dev@dpdk.org>; Mon, 11 Dec 2017 20:50:44 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Dec 2017 11:50:42 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,392,1508828400"; d="scan'208";a="1617516" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by fmsmga007.fm.intel.com with ESMTP; 11 Dec 2017 11:50:42 -0800 Received: from irsmsx111.ger.corp.intel.com (10.108.20.4) by IRSMSX101.ger.corp.intel.com (163.33.3.153) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 11 Dec 2017 19:50:42 +0000 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.167]) by irsmsx111.ger.corp.intel.com ([169.254.2.30]) with mapi id 14.03.0319.002; Mon, 11 Dec 2017 19:50:42 +0000 From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com> To: Ravi Kumar <Ravi1.kumar@amd.com>, "dev@dpdk.org" <dev@dpdk.org> Thread-Topic: [dpdk-dev] [PATCH 02/11] crypto/ccp: add support for AMD CCP crypto PMD Thread-Index: AQHTad17COYqobCZfUaYA8QX/MPbgqM+nC9Q Date: Mon, 11 Dec 2017 19:50:41 +0000 Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8976CC5A884@IRSMSX108.ger.corp.intel.com> References: <1512047553-118101-1-git-send-email-Ravi1.kumar@amd.com> <1512047553-118101-2-git-send-email-Ravi1.kumar@amd.com> In-Reply-To: <1512047553-118101-2-git-send-email-Ravi1.kumar@amd.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZWRhNDgzYmQtNWRkNy00NDI2LTkyOTMtZWEzYzEwM2NlMDQwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IlwvZ3VVTlc5Q1hqMDFXNGk4U2tyTHg3a1wvZnBIWWJNd3Y3RXZIR1JNekZ0cz0ifQ== x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 02/11] crypto/ccp: add support for AMD CCP crypto PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Mon, 11 Dec 2017 19:50:45 -0000 Hi Ravi, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ravi Kumar > Sent: Thursday, November 30, 2017 1:12 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH 02/11] crypto/ccp: add support for AMD CCP > crypto PMD >=20 As I said in the another patch, you should add a commit message for complex= patches like this one. Another thing that would be useful for improving the readability of the pat= chset and therefore, make a review easier, is to split a long patch in smaller patches. >>From what I have seen, you have some patches where you are adding support f= or CMAC and SHA3 algorithms. I suggest to do the same for the other algorithms that this PMD= supports. So, the first patch would have the skeleton of the PMD, and then you can ha= ve a separate patch per algorithm. Well, not necessarily, a patch per algorithm, but per subset of algorithms. I would propose one for AES-CBC/ECB/CTR, one for 3DES-CBC, one for AES-GCM and another one for SHA-x algorithms. Thanks, Pablo