From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pablo.de.lara.guarch@intel.com>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
by dpdk.org (Postfix) with ESMTP id 5ECC223D
for <dev@dpdk.org>; Tue, 19 Dec 2017 13:38:43 +0100 (CET)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga002.jf.intel.com ([10.7.209.21])
by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
19 Dec 2017 04:38:42 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.45,426,1508828400"; d="scan'208";a="19512155"
Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59])
by orsmga002.jf.intel.com with ESMTP; 19 Dec 2017 04:38:41 -0800
Received: from irsmsx155.ger.corp.intel.com (163.33.192.3) by
IRSMSX151.ger.corp.intel.com (163.33.192.59) with Microsoft SMTP Server (TLS)
id 14.3.319.2; Tue, 19 Dec 2017 12:38:40 +0000
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.167]) by
irsmsx155.ger.corp.intel.com ([169.254.14.169]) with mapi id 14.03.0319.002;
Tue, 19 Dec 2017 12:38:40 +0000
From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: Shahaf Shuler <shahafs@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>, "Nicolau, Radu"
<radu.nicolau@intel.com>, "arybchenko@solarflare.com"
<arybchenko@solarflare.com>
Thread-Topic: [dpdk-dev] [PATCH v2 15/39] examples/ipsec-secgw: convert to
new ethdev offloads API
Thread-Index: AQHTc0UQZxHADk2H7U6RgbdVwSM/RqNKpKUA
Date: Tue, 19 Dec 2017 12:38:38 +0000
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8976CC5F95B@IRSMSX108.ger.corp.intel.com>
References: <20171123121419.144132-1-shahafs@mellanox.com>
<cover.1513081087.git.shahafs@mellanox.com>
<2cde002e4430cdc6ad44d6d1801994171b7a8340.1513081087.git.shahafs@mellanox.com>
In-Reply-To: <2cde002e4430cdc6ad44d6d1801994171b7a8340.1513081087.git.shahafs@mellanox.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzk3NDk1ZTItNmNjNy00Y2E5LTk2YmItMjg5MDI4MTUxMTJmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6InZ5eE5pOFhJUEZUVmpxdXN6Wlo0d25cL1J1RDlcL0IrSVdXUyszY3Y2bWZnQT0ifQ==
x-ctpclassification: CTP_IC
dlp-product: dlpe-windows
dlp-version: 11.0.0.116
dlp-reaction: no-action
x-originating-ip: [163.33.239.182]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v2 15/39] examples/ipsec-secgw: convert to
new ethdev offloads API
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Dec 2017 12:38:43 -0000
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Shahaf Shuler
> Sent: Tuesday, December 12, 2017 12:27 PM
> To: dev@dpdk.org; Ananyev, Konstantin <konstantin.ananyev@intel.com>;
> Nicolau, Radu <radu.nicolau@intel.com>; arybchenko@solarflare.com
> Subject: [dpdk-dev] [PATCH v2 15/39] examples/ipsec-secgw: convert to
> new ethdev offloads API
>=20
> Ethdev offloads API has changed since:
>=20
> commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") commit
> cba7f53b717d ("ethdev: introduce Tx queue offloads API")
>=20
> This commit support the new API.
>=20
> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
> ---
> examples/ipsec-secgw/ipsec-secgw.c | 26 ++++++++++++++++++++++++--
> 1 file changed, 24 insertions(+), 2 deletions(-)
>=20
> diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-
> secgw/ipsec-secgw.c
> index c98454a..1e8af8d 100644
> --- a/examples/ipsec-secgw/ipsec-secgw.c
> +++ b/examples/ipsec-secgw/ipsec-secgw.c
> @@ -217,6 +217,9 @@ struct lcore_conf {
> },
> .txmode =3D {
> .mq_mode =3D ETH_MQ_TX_NONE,
> + .offloads =3D (DEV_TX_OFFLOAD_IPV4_CKSUM |
> + DEV_TX_OFFLOAD_MULTI_SEGS |
> + DEV_TX_OFFLOAD_MBUF_FAST_FREE),
Hi Shahaf,
Isn't this removing some checksums that were previously done?
Txq_flags was set to 0, which means that SCTP, UDP... checksums
are disabled now?
Regards,
Pablo