From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 6EA897D30 for ; Mon, 8 Jan 2018 11:16:03 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Jan 2018 02:16:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,330,1511856000"; d="scan'208";a="9487765" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by orsmga006.jf.intel.com with ESMTP; 08 Jan 2018 02:16:01 -0800 Received: from irsmsx112.ger.corp.intel.com (10.108.20.5) by IRSMSX152.ger.corp.intel.com (163.33.192.66) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 8 Jan 2018 10:16:00 +0000 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.167]) by irsmsx112.ger.corp.intel.com ([169.254.1.12]) with mapi id 14.03.0319.002; Mon, 8 Jan 2018 10:16:00 +0000 From: "De Lara Guarch, Pablo" To: "Nicolau, Radu" , "dev@dpdk.org" CC: "Ananyev, Konstantin" , "Yigit, Ferruh" , "Gonzalez Monroy, Sergio" , "Doherty, Declan" , "akhil.goyal@nxp.com" Thread-Topic: [PATCH 2/3] net/ixgbe: implemented security session get size Thread-Index: AQHTc0h1AljScSeFCES720cdDccqgaNp7FXw Date: Mon, 8 Jan 2018 10:15:59 +0000 Message-ID: References: <1513083027-11741-1-git-send-email-radu.nicolau@intel.com> <1513083027-11741-2-git-send-email-radu.nicolau@intel.com> In-Reply-To: <1513083027-11741-2-git-send-email-radu.nicolau@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTBmMTUzOTItYzUzNS00N2ViLTk3NTctMmM5NjUzNTEzZjljIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IkpnN1JTdzZWTThzMWxsS2RDUWZYVEdFYVJOWVNcL3dsY1FMQTBtNEFkeDJBPSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 2/3] net/ixgbe: implemented security session get size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Jan 2018 10:16:04 -0000 > -----Original Message----- > From: Nicolau, Radu > Sent: Tuesday, December 12, 2017 12:50 PM > To: dev@dpdk.org > Cc: Ananyev, Konstantin ; Yigit, Ferruh > ; Gonzalez Monroy, Sergio > ; De Lara Guarch, Pablo > ; Doherty, Declan > ; akhil.goyal@nxp.com; Nicolau, Radu > > Subject: [PATCH 2/3] net/ixgbe: implemented security session get size Use "implement" in infinitive. >=20 > Signed-off-by: Radu Nicolau > --- > drivers/net/ixgbe/ixgbe_ipsec.c | 7 +++++++ > 1 file changed, 7 insertions(+) >=20 > diff --git a/drivers/net/ixgbe/ixgbe_ipsec.c > b/drivers/net/ixgbe/ixgbe_ipsec.c index 105da11..720d6a1 100644 > --- a/drivers/net/ixgbe/ixgbe_ipsec.c > +++ b/drivers/net/ixgbe/ixgbe_ipsec.c > @@ -446,6 +446,12 @@ ixgbe_crypto_create_session(void *device, } >=20 > static int > +ixgbe_crypto_session_get_size(__rte_unused void *device) { Do you think passing device to the function prototype is needed? Are you expecting other drivers to use it? Also, move the braces to a new line (both opening and ending). > + return sizeof(struct ixgbe_crypto_session); } > + Thanks, Pablo