From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pablo.de.lara.guarch@intel.com>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
by dpdk.org (Postfix) with ESMTP id F0EFB8E01
for <dev@dpdk.org>; Mon, 8 Jan 2018 17:27:38 +0100 (CET)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga004.jf.intel.com ([10.7.209.38])
by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
08 Jan 2018 08:27:37 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.46,330,1511856000"; d="scan'208";a="165102613"
Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59])
by orsmga004.jf.intel.com with ESMTP; 08 Jan 2018 08:27:36 -0800
Received: from irsmsx112.ger.corp.intel.com (10.108.20.5) by
IRSMSX151.ger.corp.intel.com (163.33.192.59) with Microsoft SMTP Server (TLS)
id 14.3.319.2; Mon, 8 Jan 2018 16:27:34 +0000
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.167]) by
irsmsx112.ger.corp.intel.com ([169.254.1.12]) with mapi id 14.03.0319.002;
Mon, 8 Jan 2018 16:27:34 +0000
From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: Shahaf Shuler <shahafs@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>, "Nicolau, Radu"
<radu.nicolau@intel.com>, "arybchenko@solarflare.com"
<arybchenko@solarflare.com>
CC: Akhil Goyal <akhil.goyal@nxp.com>
Thread-Topic: [dpdk-dev] [PATCH v2 15/39] examples/ipsec-secgw: convert to
new ethdev offloads API
Thread-Index: AQHTc0UQZxHADk2H7U6RgbdVwSM/RqNKpKUAgAM4oYCAHHcUMA==
Date: Mon, 8 Jan 2018 16:27:34 +0000
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8976CC6A05C@IRSMSX108.ger.corp.intel.com>
References: <20171123121419.144132-1-shahafs@mellanox.com>
<cover.1513081087.git.shahafs@mellanox.com>
<2cde002e4430cdc6ad44d6d1801994171b7a8340.1513081087.git.shahafs@mellanox.com>
<E115CCD9D858EF4F90C690B0DCB4D8976CC5F95B@IRSMSX108.ger.corp.intel.com>
<VI1PR05MB31499F22EE9CA643E89B487AC30D0@VI1PR05MB3149.eurprd05.prod.outlook.com>
In-Reply-To: <VI1PR05MB31499F22EE9CA643E89B487AC30D0@VI1PR05MB3149.eurprd05.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjNkZDFiMzItZTIwZi00MGU3LTk1NTktMTg0ZGJhZDdlMTViIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6InluOEZ1S3Vpc1wvSys3RWhKUmtMbG5mamUwSUp5dUxyejhcL0xXb3MzWGZPND0ifQ==
x-ctpclassification: CTP_NT
dlp-product: dlpe-windows
dlp-version: 11.0.0.116
dlp-reaction: no-action
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v2 15/39] examples/ipsec-secgw: convert to
new ethdev offloads API
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 08 Jan 2018 16:27:39 -0000
> -----Original Message-----
> From: Shahaf Shuler [mailto:shahafs@mellanox.com]
> Sent: Thursday, December 21, 2017 1:45 PM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> dev@dpdk.org; Ananyev, Konstantin <konstantin.ananyev@intel.com>;
> Nicolau, Radu <radu.nicolau@intel.com>; arybchenko@solarflare.com
> Subject: RE: [dpdk-dev] [PATCH v2 15/39] examples/ipsec-secgw: convert to
> new ethdev offloads API
>=20
> Hi Pablo and maintainers of ipsec-secgw,
>=20
> Tuesday, December 19, 2017 2:39 PM, De Lara Guarch, Pablo
> > > diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-
> > > secgw/ipsec-secgw.c index c98454a..1e8af8d 100644
> > > --- a/examples/ipsec-secgw/ipsec-secgw.c
> > > +++ b/examples/ipsec-secgw/ipsec-secgw.c
> > > @@ -217,6 +217,9 @@ struct lcore_conf {
> > > },
> > > .txmode =3D {
> > > .mq_mode =3D ETH_MQ_TX_NONE,
> > > + .offloads =3D (DEV_TX_OFFLOAD_IPV4_CKSUM |
> > > + DEV_TX_OFFLOAD_MULTI_SEGS |
> > > + DEV_TX_OFFLOAD_MBUF_FAST_FREE),
> >
> > Hi Shahaf,
> >
> > Isn't this removing some checksums that were previously done?
> > Txq_flags was set to 0, which means that SCTP, UDP... checksums are
> > disabled now?
>=20
> You are right that before txqflags were 0, but it doesn't seem the
> application uses any Tx checksum offload beside IPv4, as seen on snipped
> code[1].
> If I was mistaken and it does uses L4 checksums then I will need to updat=
e
> this commit.
>=20
> Maintainers of this examples - can you confirm?
>=20
Akhil, Radu, could you confirm that this change is OK for the IPSec app?
There is a v3 already of this patch: http://dpdk.org/dev/patchwork/patch/32=
711/
Thanks,
Pablo