From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id CBDFE325F for ; Thu, 11 Jan 2018 17:33:06 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Jan 2018 08:33:05 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,345,1511856000"; d="scan'208";a="20196746" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by fmsmga004.fm.intel.com with ESMTP; 11 Jan 2018 08:33:04 -0800 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.167]) by IRSMSX104.ger.corp.intel.com ([163.33.3.159]) with mapi id 14.03.0319.002; Thu, 11 Jan 2018 16:33:03 +0000 From: "De Lara Guarch, Pablo" To: "Van Haaren, Harry" , "dev@dpdk.org" CC: "thomas@monjalon.net" , "Richardson, Bruce" , "Van Haaren, Harry" Thread-Topic: [dpdk-dev] [PATCH 2/2] test: add skip instead of fail, update crypto test Thread-Index: AQHTelRwwMvsTebZTUWCSktgdW0paKNu9lWA Date: Thu, 11 Jan 2018 16:33:03 +0000 Message-ID: References: <1513858050-77961-1-git-send-email-harry.van.haaren@intel.com> <1513858050-77961-2-git-send-email-harry.van.haaren@intel.com> In-Reply-To: <1513858050-77961-2-git-send-email-harry.van.haaren@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzkwYTNiNGYtM2VlNy00Y2M5LWFmMjQtYjNmOWE2MWU1Y2RmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IkNnRFgycnRjb01oXC9jQUw1ZUNVTUxFb1JFbWorS2RtWUFQNnZXZWxIUmRzPSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 2/2] test: add skip instead of fail, update crypto test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Jan 2018 16:33:07 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Harry van Haaren > Sent: Thursday, December 21, 2017 12:08 PM > To: dev@dpdk.org > Cc: thomas@monjalon.net; Richardson, Bruce > ; Van Haaren, Harry > > Subject: [dpdk-dev] [PATCH 2/2] test: add skip instead of fail, update cr= ypto > test >=20 > This commit adds a SKIPPED return value from the unit tests, indicating t= hat > the test was not able to run (eg: PMD was not enabled when DPDK was > compiled). >=20 > The cryptodev tests are updated to return SKIPPED instead of failing if t= he > PMD is not enabled, allowing any test infrastructure to identify that the= test > was not able to run. Check-git-log.sh complains about the commit title (because of the comma). I think this patch should be split into two patches: one that adds TEST_SKI= PPED and another one that updates the crypto tests (the title suggests these two= patches). Also, when running a test that returns TEST_SKIPPED, it still prints out "T= est Failed". It looks like this is caused because cmd_autotest_parsed() hasn't been upda= ted: static void cmd_autotest_parsed(void *parsed_result, __attribute__((unused)) struct cmdline *cl, __attribute__((unused)) void *data) { ... if (ret =3D=3D 0) printf("Test OK\n"); else printf("Test Failed\n"); Probably, another check should be added here. Pablo