From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 7A0E71B2A0 for ; Tue, 16 Jan 2018 16:29:52 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Jan 2018 07:29:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,368,1511856000"; d="scan'208";a="23781884" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by orsmga001.jf.intel.com with ESMTP; 16 Jan 2018 07:29:51 -0800 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.167]) by irsmsx105.ger.corp.intel.com ([169.254.7.236]) with mapi id 14.03.0319.002; Tue, 16 Jan 2018 15:29:50 +0000 From: "De Lara Guarch, Pablo" To: "Kumar, Ravi1" , "dev@dpdk.org" CC: "Shippen, Greg" Thread-Topic: [PATCH v3 01/19] crypto/ccp: add AMD ccp skeleton PMD Thread-Index: AQHTifeHujWRptOqY02EgHPZj6ejzaNs3PiwgAAK6oCAADUcEIABHCeAgAhvrtA= Date: Tue, 16 Jan 2018 15:29:49 +0000 Message-ID: References: <1515145198-97367-1-git-send-email-Ravi1.kumar@amd.com> <1515577379-18453-1-git-send-email-Ravi1.kumar@amd.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZGM3ZDYzOWUtZDY0Mi00NmE5LWI1MmUtZjc0M2IyMWU0NDFkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6InZRVTBVeitBM2RYcnJWNCtpYVJUNGtDMFdweHNzeHVFUkt0a0NoNnQ0V2M9In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 01/19] crypto/ccp: add AMD ccp skeleton PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Jan 2018 15:29:54 -0000 Hi Ravi, > -----Original Message----- > From: Kumar, Ravi1 [mailto:Ravi1.Kumar@amd.com] > Sent: Thursday, January 11, 2018 6:37 AM > To: De Lara Guarch, Pablo ; > dev@dpdk.org > Cc: Shippen, Greg > Subject: RE: [PATCH v3 01/19] crypto/ccp: add AMD ccp skeleton PMD >=20 > > -----Original Message----- > >> From: Kumar, Ravi1 [mailto:Ravi1.Kumar@amd.com] > >> Sent: Wednesday, January 10, 2018 10:30 AM > >> To: De Lara Guarch, Pablo ; > >> dev@dpdk.org > >> Cc: Shippen, Greg > >> Subject: RE: [PATCH v3 01/19] crypto/ccp: add AMD ccp skeleton PMD > >> > >> >Hi Ravi, > >> > > >> >> -----Original Message----- > >> >> From: Ravi Kumar [mailto:Ravi1.kumar@amd.com] > >> >> Sent: Wednesday, January 10, 2018 9:43 AM > >> >> To: dev@dpdk.org > >> >> Cc: De Lara Guarch, Pablo > >> >> Subject: [PATCH v3 01/19] crypto/ccp: add AMD ccp skeleton PMD > >> >> > >> >> Signed-off-by: Ravi Kumar > >> >> --- > >> > > >> >... > >> > > >> >> --- /dev/null > >> >> +++ b/drivers/crypto/ccp/Makefile > >> >> @@ -0,0 +1,55 @@ > >> >> +# > >> >> +# Copyright(c) 2018 Advanced Micro Devices, Inc. > >> >> +# All rights reserved. > >> >> +# > >> > > >> >As Hemant commented, you need to change this full license with SPDX > >> tags: > >> > > >> >http://dpdk.org/ml/archives/dev/2018-January/085510.html > >> > > >> >Could you submit a v4 with these changes today? > >> > > >> >Thanks, > >> >Pablo > >> > >> Hi Pablo, > >> > >> Our legal team is still working on the license. We want to get the > >> code reviewed in parallel. > >> I will give you and update later if we can upload the v4 patch with > >> SPDX tags today. > >> > > > >Ok, I have looked at the overall patchset and it looks ok to me. > >The only thing that I would change is the title of patch 7/19: > >I would change it to "crypto/ccp: support sessionless operations". > > > >Regards, > >Pablo >=20 > Hi Pablo, >=20 > Thanks for going through our code. Good to know the code is fine. >=20 > The new changes in licensing policy has introduced some delays as we work > through the implications and get agreement from the third party. >=20 > We are working on it and will upload the v4 with SPDX license tags as soo= n > as possible. >=20 Any news? RC1 will be out on Friday, and the subtree should be close tomorr= ow evening, and there will not be more features added after this point. Thanks, Pablo > Regards, > Ravi > > > >> Regards, > >> Ravi