From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 9C3F81B2D7 for ; Fri, 19 Jan 2018 10:33:24 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Jan 2018 01:33:23 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,381,1511856000"; d="scan'208";a="21009477" Received: from irsmsx154.ger.corp.intel.com ([163.33.192.96]) by FMSMGA003.fm.intel.com with ESMTP; 19 Jan 2018 01:33:22 -0800 Received: from irsmsx112.ger.corp.intel.com (10.108.20.5) by IRSMSX154.ger.corp.intel.com (163.33.192.96) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 19 Jan 2018 09:33:21 +0000 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.167]) by irsmsx112.ger.corp.intel.com ([169.254.1.12]) with mapi id 14.03.0319.002; Fri, 19 Jan 2018 09:33:21 +0000 From: "De Lara Guarch, Pablo" To: =?iso-8859-1?Q?N=E9lio_Laranjeiro?= , Olivier Matz CC: "dev@dpdk.org" , "borisp@mellanox.com" Thread-Topic: [dpdk-dev] [PATCH 1/2] net: fix ESP header byte ordering definition Thread-Index: AQHTjtW92mM0iTobF0GZ85w0moF8GaN2pjmAgARM8xA= Date: Fri, 19 Jan 2018 09:33:20 +0000 Message-ID: References: <20180116142409.yazvskvhlgsrzuib@platinum> <20180116155201.zz6frinsqyjlxdqo@laranjeiro-vm.dev.6wind.com> In-Reply-To: <20180116155201.zz6frinsqyjlxdqo@laranjeiro-vm.dev.6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzQ0ODM0ZjAtMjg1Ny00NWRlLWFlN2EtOGFiOTZiMzA3ZTk2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IlpvdjEwcEhEMHN4V1FycXlNOEdvVGtyaWpOUEhDKzJHZlozNUJ0VXBmTDg9In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 1/2] net: fix ESP header byte ordering definition X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Jan 2018 09:33:25 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of N=E9lio Laranjeiro > Sent: Tuesday, January 16, 2018 3:52 PM > To: Olivier Matz > Cc: dev@dpdk.org; borisp@mellanox.com > Subject: Re: [dpdk-dev] [PATCH 1/2] net: fix ESP header byte ordering > definition >=20 > On Tue, Jan 16, 2018 at 03:24:09PM +0100, Olivier Matz wrote: > > On Thu, Jan 11, 2018 at 10:15:58AM +0100, Nelio Laranjeiro wrote: > > > ESP header is defined in the RFC2406 [1] as Big Endian fields it > > > should use the corresponding types in DPDK as well. > > > > > > Fixes: d4b684f7197a ("net: add ESP header to generic flow steering") > > > > I wonder if we should really mark this as a fix. >=20 > I also agree, the point is some examples application have started using i= t as > CPU order instead of Network order, this patch also needs to be applied i= n > stable branch before fixing the code using it. If you want a patch to be applied in stable branch, don't forget to CC stab= le@dpdk.org, and add it under the fixes tag. Thanks, Pabo