From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: Tomasz Duszynski <tdu@semihalf.com>
Cc: "Doherty, Declan" <declan.doherty@intel.com>,
"jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com>,
"jck@semihalf.com" <jck@semihalf.com>,
"dima@marvell.com" <dima@marvell.com>,
"nsamsono@marvell.com" <nsamsono@marvell.com>,
"jianbo.liu@arm.org" <jianbo.liu@arm.org>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] cryptodev: remove duplicated device name length
Date: Fri, 19 Jan 2018 10:41:05 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8976CC74EE8@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <20171214092819.GA5495@tdu>
> -----Original Message-----
> From: Tomasz Duszynski [mailto:tdu@semihalf.com]
> Sent: Thursday, December 14, 2017 9:28 AM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Cc: Doherty, Declan <declan.doherty@intel.com>;
> jerin.jacob@caviumnetworks.com; jck@semihalf.com; tdu@semihalf.com;
> dima@marvell.com; nsamsono@marvell.com; jianbo.liu@arm.org;
> dev@dpdk.org
> Subject: Re: [PATCH] cryptodev: remove duplicated device name length
>
> On Wed, Dec 13, 2017 at 03:54:08PM +0000, Pablo de Lara wrote:
> > Two macros were defined in cryptodev, to serve the same
> > purpose: RTE_CRYPTODEV_NAME_LEN (in the config file) and
> > RTE_CRYPTODEV_NAME_MAX_LEN (in the rte_cryptodev.h file).
> > Since the second one is part of the external API, the first one has
> > been removed, avoiding duplications.
> >
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
...
> As for mrvl crypto pmd:
> Acked-by: Tomasz Duszynski <tdu@semihalf.com>
I am aware that this patch is removing a configuration option, that was used
in an internal app (so it could potentially be used in other apps).
This shouldn't be the case, plus this macro is duplicated, so apps and PMDs
should use the macro in the cryptodev header file.
Applied to dpdk-next-crypto.
Pablo
prev parent reply other threads:[~2018-01-19 10:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-13 15:54 Pablo de Lara
2017-12-14 9:28 ` Tomasz Duszynski
2018-01-19 10:41 ` De Lara Guarch, Pablo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8976CC74EE8@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=dima@marvell.com \
--cc=jck@semihalf.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=jianbo.liu@arm.org \
--cc=nsamsono@marvell.com \
--cc=tdu@semihalf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).