From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id A96641B3BF; Mon, 29 Jan 2018 10:14:53 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Jan 2018 01:14:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,429,1511856000"; d="scan'208";a="13366762" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by orsmga007.jf.intel.com with ESMTP; 29 Jan 2018 01:14:51 -0800 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.9]) by IRSMSX107.ger.corp.intel.com ([169.254.10.46]) with mapi id 14.03.0319.002; Mon, 29 Jan 2018 09:14:50 +0000 From: "De Lara Guarch, Pablo" To: "Richardson, Bruce" , "Zhang, Roy Fan" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] crypto/scheduler: fix strncpy length Thread-Index: AQHTlrQsEB+tkK+MUkShm84k2fLL7qOGPGEAgARXerA= Date: Mon, 29 Jan 2018 09:14:50 +0000 Message-ID: References: <20180126144428.13154-1-pablo.de.lara.guarch@intel.com> <59AF69C657FD0841A61C55336867B5B07223CBF2@IRSMSX103.ger.corp.intel.com> In-Reply-To: <59AF69C657FD0841A61C55336867B5B07223CBF2@IRSMSX103.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjk1ZGMzMmMtZmY3OS00YzhkLWJmZjYtYzJiZWE3YjIwMGYwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6InNDSXcwTytGTU5TV1lDK3plaDFjSjNuOGc1SUpVUGtUU1I1S2R3YXlKSnc9In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] crypto/scheduler: fix strncpy length X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Jan 2018 09:14:54 -0000 > -----Original Message----- > From: Richardson, Bruce > Sent: Friday, January 26, 2018 2:50 PM > To: De Lara Guarch, Pablo ; Zhang, Roy > Fan > Cc: dev@dpdk.org; De Lara Guarch, Pablo > ; stable@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] crypto/scheduler: fix strncpy length >=20 >=20 >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara > > Sent: Friday, January 26, 2018 2:44 PM > > To: Zhang, Roy Fan > > Cc: dev@dpdk.org; De Lara Guarch, Pablo > > ; stable@dpdk.org > > Subject: [dpdk-dev] [PATCH] crypto/scheduler: fix strncpy length > > > > The coverity issue was not completely fixed, since strncpy should be > > called with max length - 1. > > > > Coverity issue: 143431 > > Fixes: d040aca67170 ("crypto/scheduler: fix strings not null > > terminated") > > Cc: stable@dpdk.org > > > > Signed-off-by: Pablo de Lara >=20 > Use "snprintf", please, to fix these errors sanely without having to worr= y > about off-by-one issues! >=20 > /Bruce Thanks for the comment. Will send a v2 shortly. Pablo=20