Re: [dpdk-dev] [PATCH] crypto/mrvl: add MRVL to hash test cases

["De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>]

Hi Tomasz,

> -----Original Message-----
> From: Tomasz Duszynski [mailto:tdu@semihalf.com]
> Sent: Thursday, March 8, 2018 1:27 PM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Doherty,
> Declan <declan.doherty@intel.com>; Richardson, Bruce
> <bruce.richardson@intel.com>; Tomasz Duszynski <tdu@semihalf.com>;
> stable@dpdk.org
> Subject: Re: [PATCH] crypto/mrvl: add MRVL to hash test cases
> 

This is targetting the crypto tests, so title should be "test/crypto: ... "


> This patch has been here for a while already. Should I respin it?
> 
> On Wed, Feb 28, 2018 at 03:53:53PM +0100, Tomasz Duszynski wrote:
> > MRVL Crypto PMD supports most of the hash algorithms covered by test
> > suites thus specific bits should be set in pmd_masks.
> >
> > Otherwise blockcipher authonly test returns success even though no
> > real tests have been executed.

> >
> > Fixes: 84e0ded38ac5 ("test/crypto: add mrvl crypto unit tests")
> > Cc: stable@dpdk.org

I don't think this is a fix, so I would remove the fixes and CC stable lines.

Thanks,
Pablo

> >
> > Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>