Re: [dpdk-dev] [PATCH] crypto/mrvl: add MRVL to hash test cases

["De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>]

> -----Original Message-----
> From: Tomasz Duszynski [mailto:tdu@semihalf.com]
> Sent: Wednesday, March 14, 2018 10:30 AM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Cc: Tomasz Duszynski <tdu@semihalf.com>; dev@dpdk.org; Doherty,
> Declan <declan.doherty@intel.com>; Richardson, Bruce
> <bruce.richardson@intel.com>; stable@dpdk.org
> Subject: Re: [PATCH] crypto/mrvl: add MRVL to hash test cases
> 
> On Wed, Mar 14, 2018 at 10:13:58AM +0000, De Lara Guarch, Pablo wrote:
> > Hi Tomasz,
> >
> > > -----Original Message-----
> > > From: Tomasz Duszynski [mailto:tdu@semihalf.com]
> > > Sent: Thursday, March 8, 2018 1:27 PM
> > > To: dev@dpdk.org
> > > Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Doherty,
> > > Declan <declan.doherty@intel.com>; Richardson, Bruce
> > > <bruce.richardson@intel.com>; Tomasz Duszynski
> <tdu@semihalf.com>;
> > > stable@dpdk.org
> > > Subject: Re: [PATCH] crypto/mrvl: add MRVL to hash test cases
> > >
> >
> > This is targetting the crypto tests, so title should be "test/crypto: ... "
> 
> Ack.
> 
> >
> >
> > > This patch has been here for a while already. Should I respin it?
> > >
> > > On Wed, Feb 28, 2018 at 03:53:53PM +0100, Tomasz Duszynski wrote:
> > > > MRVL Crypto PMD supports most of the hash algorithms covered by
> > > > test suites thus specific bits should be set in pmd_masks.
> > > >
> > > > Otherwise blockcipher authonly test returns success even though no
> > > > real tests have been executed.
> >
> > > >
> > > > Fixes: 84e0ded38ac5 ("test/crypto: add mrvl crypto unit tests")
> > > > Cc: stable@dpdk.org
> >
> > I don't think this is a fix, so I would remove the fixes and CC stable lines.
> 
> Why? I think this should have been here since introduction on mrvl/cryto.
> If you take a look at 84e0ded38ac5 there is test called:
> test_authonly_mrvl_all() which runs blockcipher tests with
> BLKCIPHER_AUTHONLY_TYPE flag.
> 
> Since MRVL pmd flag was missing from pmd_mask in
> blockcipher_test_case_hash_test_cases table tests were not run. Moreover
> overall_status variable was not touched thus test suite completed without
> errors.

Right, I thought that this patch was just adding the PMD to the hast test cases,
I wasn't looking at it from a fix point of view, but I guess you are right.

Thanks for clarifying.
Pablo

> 
> >
> > Thanks,
> > Pablo
> >
> > > >
> > > > Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
> >
> 
> --
> - Tomasz Duszyński