From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 6E7A91C6D1 for ; Fri, 13 Apr 2018 20:55:27 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Apr 2018 11:55:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,446,1517904000"; d="scan'208";a="32487311" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by fmsmga008.fm.intel.com with ESMTP; 13 Apr 2018 11:55:24 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.155]) by IRSMSX101.ger.corp.intel.com ([169.254.1.176]) with mapi id 14.03.0319.002; Fri, 13 Apr 2018 19:55:23 +0100 From: "De Lara Guarch, Pablo" To: "Gujjar, Abhinandan S" , "Doherty, Declan" , "jerin.jacob@caviumnetworks.com" , "hemant.agrawal@nxp.com" , "akhil.goyal@nxp.com" , "dev@dpdk.org" CC: "Vangati, Narender" , "Rao, Nikhil" Thread-Topic: [dpdk-dev,v1,2/3] cryptodev: add support to set session private data Thread-Index: AQHTy97v5sWJ5jFhoUmQUtjLV4doeaP/E+rA Date: Fri, 13 Apr 2018 18:55:22 +0000 Message-ID: References: <1522823656-59973-1-git-send-email-abhinandan.gujjar@intel.com> In-Reply-To: <1522823656-59973-1-git-send-email-abhinandan.gujjar@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjMwZTM0MmMtMmI3NC00Mzc0LWI2ZDYtY2ZkMDI1Mzk3YTBkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6ImRcLzBMVUp2WW9iMmNyeDBsbWsyTVNGVmFRMFwva01sSmN2cXhZSDBtQ2gwOD0ifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [dpdk-dev, v1, 2/3] cryptodev: add support to set session private data X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Apr 2018 18:55:28 -0000 Hi Abhinandan, > -----Original Message----- > From: Gujjar, Abhinandan S > Sent: Wednesday, April 4, 2018 7:34 AM > To: De Lara Guarch, Pablo ; Doherty, Decl= an > ; jerin.jacob@caviumnetworks.com; > hemant.agrawal@nxp.com; akhil.goyal@nxp.com; dev@dpdk.org > Cc: Vangati, Narender ; Gujjar, Abhinandan S > ; Rao, Nikhil > Subject: [dpdk-dev,v1,2/3] cryptodev: add support to set session private = data >=20 Generally, it is better to directly use "support" in the title, and not "ad= d support". Maybe better write: "cryptodev: support session private data setting" ... > diff --git a/lib/librte_cryptodev/rte_cryptodev_version.map > b/lib/librte_cryptodev/rte_cryptodev_version.map > index eb47308..c3a3fda 100644 > --- a/lib/librte_cryptodev/rte_cryptodev_version.map > +++ b/lib/librte_cryptodev/rte_cryptodev_version.map > @@ -85,3 +85,10 @@ DPDK_17.11 { > rte_cryptodev_pmd_parse_input_args; >=20 > } DPDK_17.08; > + > +DPDK_18.05 { > + global: > + > + rte_cryptodev_sym_session_set_private_data; > + rte_cryptodev_sym_session_get_private_data; This list has to be in alphabetical order. Rest looks good to me, so: Acked-by: Pablo de Lara Lastly, since Akhil has acked the patch, you can add his and my ack in v2. Thanks, Pablo