From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: "Gujjar, Abhinandan S" <abhinandan.gujjar@intel.com>,
Akhil Goyal <akhil.goyal@nxp.com>,
"Doherty, Declan" <declan.doherty@intel.com>,
"jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com>,
"hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Vangati, Narender" <narender.vangati@intel.com>,
"Rao, Nikhil" <nikhil.rao@intel.com>
Subject: Re: [dpdk-dev] [v3,3/3] doc: add private data info in crypto guide
Date: Tue, 17 Apr 2018 13:49:20 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8976CCD63F5@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <5612CB344B05EE4F95FC5B729939F780706E4CB4@PGSMSX102.gar.corp.intel.com>
Hi,
> -----Original Message-----
> From: Gujjar, Abhinandan S
> Sent: Monday, April 16, 2018 10:36 AM
> To: Akhil Goyal <akhil.goyal@nxp.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>; Doherty, Declan
> <declan.doherty@intel.com>; jerin.jacob@caviumnetworks.com;
> hemant.agrawal@nxp.com; dev@dpdk.org
> Cc: Vangati, Narender <narender.vangati@intel.com>; Rao, Nikhil
> <nikhil.rao@intel.com>
> Subject: RE: [v3,3/3] doc: add private data info in crypto guide
>
> Hi Akhil,
>
> Missed out the *series* and thought the ack was only on the doc patch.
> Regarding change log, Just before posting I looked at recent patches.
> Most of them, didn't have change log! So, I didn't add it.
> Yes, there is a typo in the subject of this patch. Does this require newer version
> of patches?
Unless there is something else to change, there is no need to send another patchset
just for this typo.
About changelog, it is a good practice to add it. Also, for patchsets, it is good to
add a cover letter, and there you could add the changelog for the entire patchset.
Thanks,
Pablo
next prev parent reply other threads:[~2018-04-17 13:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-16 6:54 [dpdk-dev] [v2, 1/3] cryptodev: set private data for session-less mode Abhinandan Gujjar
2018-04-16 6:54 ` [dpdk-dev] [v2, 2/3] cryptodev: support session private data setting Abhinandan Gujjar
2018-04-19 12:16 ` Verma, Shally
2018-04-20 12:20 ` Gujjar, Abhinandan S
2018-04-20 12:23 ` Verma, Shally
2018-04-16 6:54 ` [dpdk-dev] [v3,3/3] doc: add private data info in crypto guide Abhinandan Gujjar
2018-04-16 9:16 ` Akhil Goyal
2018-04-16 9:36 ` Gujjar, Abhinandan S
2018-04-17 13:49 ` De Lara Guarch, Pablo [this message]
2018-04-17 13:57 ` [dpdk-dev] [v2, 1/3] cryptodev: set private data for session-less mode De Lara Guarch, Pablo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8976CCD63F5@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=abhinandan.gujjar@intel.com \
--cc=akhil.goyal@nxp.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=narender.vangati@intel.com \
--cc=nikhil.rao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).