From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 9EEB3231E for ; Mon, 23 Apr 2018 12:05:10 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Apr 2018 03:05:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,317,1520924400"; d="scan'208";a="52902855" Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25]) by orsmga002.jf.intel.com with ESMTP; 23 Apr 2018 03:05:08 -0700 Received: from irsmsx111.ger.corp.intel.com (10.108.20.4) by irsmsx110.ger.corp.intel.com (163.33.3.25) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 23 Apr 2018 11:05:07 +0100 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.155]) by irsmsx111.ger.corp.intel.com ([169.254.2.167]) with mapi id 14.03.0319.002; Mon, 23 Apr 2018 11:05:07 +0100 From: "De Lara Guarch, Pablo" To: Thomas Monjalon , "Kumar, Ravi1" CC: "dev@dpdk.org" , "hemant.agrawal@nxp.com" Thread-Topic: [dpdk-dev] [PATCH v5 17/19] crypto/ccp: support cpu based md5 and sha2 family authentication algo Thread-Index: AQHTv31K7SU2KUOvEkChaa79Uh9zsqQNW8GAgACwqQCAABecAIAAMQ1g Date: Mon, 23 Apr 2018 10:05:06 +0000 Message-ID: References: <1520584520-130522-1-git-send-email-Ravi1.kumar@amd.com> <14946114.ASIPbkMQcp@xps> <1698373.c9XDPgIzTm@xps> In-Reply-To: <1698373.c9XDPgIzTm@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzM3ZmM4ZjctZDA1NC00OTY1LWI0ZTktNmQwOGNkMzU0NmI3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IlZKVlVwSXNJUGN4WmhYaWY3RFBMMkxPWGdab2h0QkRHZlR5MmZEOVZqVmM9In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5 17/19] crypto/ccp: support cpu based md5 and sha2 family authentication algo X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Apr 2018 10:05:11 -0000 Hi Ravi, > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Monday, April 23, 2018 9:06 AM > To: Kumar, Ravi1 > Cc: De Lara Guarch, Pablo ; dev@dpdk.org; > hemant.agrawal@nxp.com > Subject: Re: [dpdk-dev] [PATCH v5 17/19] crypto/ccp: support cpu based md= 5 > and sha2 family authentication algo >=20 > 23/04/2018 08:41, Kumar, Ravi1: > > >> +CONFIG_RTE_LIBRTE_PMD_CCP_CPU_AUTH=3Dn > > > > > >Why introducing a compile-time option? > > >Can it be a run-time option of the device? > > >We must not add compile-time device option if not well justified. > [...] > > By default, all the crypto operations (cipher + auth) are offloaded to = CCP > engines. When user enables CONFIG_RTE_LIBRTE_PMD_CCP_CPU_AUTH=3Dy, the > auth operations are not offloaded to CCP and rather performed over CPU. W= e > kept this feature as a compile time option in order to let user decide wh= ether to > run auth operations on CCP or CPU as some of the auth operations performs > faster on CPU as compared to their performance on CCP. >=20 > No, you do not let the user decide. > The compilation options are for the packager to decide. > The user can rely on pre-compiled packages and use only runtime options. > That's why we forbid compile-time options for such features. >=20 Could you send a patch to remove this compile-time option and pass it as an= option for the vdev? Look at how the crypto scheduler accepts parameters from "rte_vdev_init" or= --vdev, in scheduler_pmd.c. Thanks! Pablo