From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pablo.de.lara.guarch@intel.com> Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 8C15E2C12 for <dev@dpdk.org>; Tue, 24 Apr 2018 16:18:09 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Apr 2018 07:18:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,323,1520924400"; d="scan'208";a="35774813" Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25]) by orsmga007.jf.intel.com with ESMTP; 24 Apr 2018 07:18:07 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.155]) by irsmsx110.ger.corp.intel.com ([169.254.15.211]) with mapi id 14.03.0319.002; Tue, 24 Apr 2018 15:18:07 +0100 From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com> To: "Chalupnik, KamilX" <kamilx.chalupnik@intel.com>, "dev@dpdk.org" <dev@dpdk.org> CC: "Mokhtar, Amr" <amr.mokhtar@intel.com>, "Chalupnik, KamilX" <kamilx.chalupnik@intel.com> Thread-Topic: [dpdk-dev] [PATCH] app/bbdev: dynamic lib support Thread-Index: AQHTzB5WbYdJWBOtYEmRu+DkPJ1VhaQQFMBg Date: Tue, 24 Apr 2018 14:18:06 +0000 Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8976CCDBEEF@IRSMSX108.ger.corp.intel.com> References: <20180404140602.9344-1-kamilx.chalupnik@intel.com> <20180404140602.9344-8-kamilx.chalupnik@intel.com> In-Reply-To: <20180404140602.9344-8-kamilx.chalupnik@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiY2ZkMDE0MmMtZDUyMy00YjJmLTkwOTAtODZjNGQwOTFlOTA1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IlE5K01aNWR6N2J0NnpOSEMyYU9WRGNOU0FkMTNiV0orTHNnZDBKakpSNzA9In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] app/bbdev: dynamic lib support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Tue, 24 Apr 2018 14:18:10 -0000 Hi Kamil, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of KamilX Chalupnik > Sent: Wednesday, April 4, 2018 3:06 PM > To: dev@dpdk.org > Cc: Mokhtar, Amr <amr.mokhtar@intel.com>; Chalupnik, KamilX > <kamilx.chalupnik@intel.com> > Subject: [dpdk-dev] [PATCH] app/bbdev: dynamic lib support >=20 > From: "Chalupnik, KamilX" <kamilx.chalupnik@intel.com> >=20 > Support for linking with dynamic library added in Baseband Device test > application >=20 > Signed-off-by: KamilX Chalupnik <kamilx.chalupnik@intel.com> > --- > app/test-bbdev/Makefile | 4 ++++ > doc/guides/tools/testbbdev.rst | 7 +++++++ > 2 files changed, 11 insertions(+) >=20 > diff --git a/app/test-bbdev/Makefile b/app/test-bbdev/Makefile index > 6da0c8e..26c9a4b 100644 > --- a/app/test-bbdev/Makefile > +++ b/app/test-bbdev/Makefile > @@ -22,4 +22,8 @@ SRCS-$(CONFIG_RTE_TEST_BBDEV) +=3D > test_bbdev_vector.c >=20 > LDLIBS +=3D -lm >=20 > +ifeq ($(CONFIG_RTE_LIBRTE_PMD_BBDEV_TURBO_SW),y) > +LDLIBS +=3D -lrte_pmd_bbdev_turbo_sw > +endif This is already done in mk/rte.app.mk, so it should not be needed. > + > include $(RTE_SDK)/mk/rte.app.mk > diff --git a/doc/guides/tools/testbbdev.rst b/doc/guides/tools/testbbdev.= rst > index 2ccc646..8a13cbd 100644 > --- a/doc/guides/tools/testbbdev.rst > +++ b/doc/guides/tools/testbbdev.rst > @@ -36,6 +36,13 @@ The user must have all libraries, modules, updates and > compilers installed in the system prior to this, as described in the ear= lier > chapters in this Getting Started Guide. >=20 > +Compiling the Application with DPDK built as shared library > +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > + > +Setting flag in config/common_base file: > + > + ``CONFIG_RTE_BUILD_SHARED_LIB=3Dy`` I don't think this is necessary to document. This is global for all applications and libraries in DPDK, and none of them= document individually this. In a nutshell, I think this patch is not necessary. Thanks, Pablo