From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 672DC2C17 for ; Tue, 24 Apr 2018 16:56:56 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Apr 2018 07:56:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,323,1520924400"; d="scan'208";a="40097111" Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by fmsmga002.fm.intel.com with ESMTP; 24 Apr 2018 07:56:52 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.155]) by IRSMSX103.ger.corp.intel.com ([169.254.3.61]) with mapi id 14.03.0319.002; Tue, 24 Apr 2018 15:56:51 +0100 From: "De Lara Guarch, Pablo" To: "Chalupnik, KamilX" , "dev@dpdk.org" CC: "Mokhtar, Amr" , "Chalupnik, KamilX" Thread-Topic: [dpdk-dev] [PATCH] app/bbdev: update test vectors Thread-Index: AQHTzLLqmx0eiC8y7E2c3dBNHUv6+6QQHadA Date: Tue, 24 Apr 2018 14:56:51 +0000 Message-ID: References: <20180404140602.9344-1-kamilx.chalupnik@intel.com> <20180404140602.9344-7-kamilx.chalupnik@intel.com> In-Reply-To: <20180404140602.9344-7-kamilx.chalupnik@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjdhMDZiOTQtZGQwMy00Y2RhLWExMjEtZmYzYjA1YThhMTNhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IkVHM3JZa3dqU1NaWXRHakVcL1dPQStGMnp3NWE5UXAzbmVqdU83Y0YyYkZ3PSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] app/bbdev: update test vectors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Apr 2018 14:56:58 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of KamilX Chalupnik > Sent: Wednesday, April 4, 2018 3:06 PM > To: dev@dpdk.org > Cc: Mokhtar, Amr ; Chalupnik, KamilX > > Subject: [dpdk-dev] [PATCH] app/bbdev: update test vectors >=20 > From: "Chalupnik, KamilX" >=20 > Update test vectors directory for Wireless Baseband Device: > - creation of new vectors to test and validate BBDevice capabilities > - python script used for tests execution updated >=20 > Update the test app documentation: > - vector test names updated > - description of tests added > - usage of test app updated >=20 > Signed-off-by: KamilX Chalupnik Could you split this patch into multiple patches? You are doing several thi= ngs here, so it is better to split each thing into a different patch. Make sure that the functionality and compilation is not broken for each pat= ch. I think you can have a patch updating the names of current tests (updating = the documentation in the same patch), another patch adding the new tests (also updating the documentation) and a = last patch with the rest of the documentation changes. This way, it will be easier to review. Also, another comment below. > --- a/doc/guides/tools/testbbdev.rst > +++ b/doc/guides/tools/testbbdev.rst ... >=20 > ./test-bbdev.py -p ../../x86_64-native-linuxapp-icc/app/testbbdev > - -v ./test_vectors/bbdev_vector_td_default.data > + -v turbo_dec_default.data Shouldn't this be still under test_vectors?