From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 861614C76 for ; Tue, 24 Apr 2018 19:53:57 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Apr 2018 10:53:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,324,1520924400"; d="scan'208";a="35831428" Received: from irsmsx108.ger.corp.intel.com ([163.33.3.3]) by orsmga007.jf.intel.com with ESMTP; 24 Apr 2018 10:53:54 -0700 Received: from irsmsx156.ger.corp.intel.com (10.108.20.68) by IRSMSX108.ger.corp.intel.com (163.33.3.3) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 24 Apr 2018 18:53:33 +0100 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.155]) by IRSMSX156.ger.corp.intel.com ([169.254.3.229]) with mapi id 14.03.0319.002; Tue, 24 Apr 2018 18:53:33 +0100 From: "De Lara Guarch, Pablo" To: "Chalupnik, KamilX" , "dev@dpdk.org" CC: "Mokhtar, Amr" , "Chalupnik, KamilX" Thread-Topic: [dpdk-dev] [PATCH v2] baseband/turbo_sw: optimization of turbo software driver Thread-Index: AQHT1llqnUW7PtFkFUe45q4OXbv5TqQQO/uw Date: Tue, 24 Apr 2018 17:53:33 +0000 Message-ID: References: <20180404140602.9344-3-kamilx.chalupnik@intel.com> <20180417143408.3520-1-kamilx.chalupnik@intel.com> In-Reply-To: <20180417143408.3520-1-kamilx.chalupnik@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzVkNDA1MzgtNmU4Mi00YzFkLTkyODctNWZmZmU0YzZhNDFkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IktTNmFLU0RjR09ER09mZTJWZ1h5ckJKSFBhXC80d2JURUZNM3VXM3pGQ0t3PSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] baseband/turbo_sw: optimization of turbo software driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Apr 2018 17:53:59 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of KamilX Chalupnik > Sent: Tuesday, April 17, 2018 3:34 PM > To: dev@dpdk.org > Cc: Mokhtar, Amr ; Chalupnik, KamilX > > Subject: [dpdk-dev] [PATCH v2] baseband/turbo_sw: optimization of turbo > software driver Optimization of the driver is not a good title, in my opinion. Instead, call out what you are actually changing. You should separate this patch into two patches, based on the two bullet po= ints below. >=20 > Optimization of Turbo Software driver: > - resource-hungry piece of code removed or optimized > - validation of decoder/encoder parameters put under debug flug >=20 ... >=20 > +#ifdef RTE_LIBRTE_BBDEV_DEBUG Where is this macro defined? In DPDK we are avoiding the use of compile time options when possible, so it is a better idea to use a runtime option to avoid the execution of pa= rt of the code (passed through device configuration maybe?). Otherwise, compilation checki= ng gets more difficult.