From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id D1AF1235 for ; Wed, 25 Apr 2018 09:37:48 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Apr 2018 00:37:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,325,1520924400"; d="scan'208";a="36265171" Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by orsmga008.jf.intel.com with ESMTP; 25 Apr 2018 00:37:46 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.155]) by IRSMSX151.ger.corp.intel.com ([169.254.4.122]) with mapi id 14.03.0319.002; Wed, 25 Apr 2018 08:37:45 +0100 From: "De Lara Guarch, Pablo" To: "Mokhtar, Amr" , "Chalupnik, KamilX" , "dev@dpdk.org" CC: "Chalupnik, KamilX" Thread-Topic: [dpdk-dev] [PATCH v2] baseband/turbo_sw: update Turbo Software driver Thread-Index: AQHT1lrA4KT9KdqwF0qV1dXAqUY/16QQPawg////54CAAOSTsA== Date: Wed, 25 Apr 2018 07:37:44 +0000 Message-ID: References: <20180404140602.9344-5-kamilx.chalupnik@intel.com> <20180417144359.29232-1-kamilx.chalupnik@intel.com> <3D3765A8CDB52A4C8B410430AA19CB236ECBD1F2@IRSMSX104.ger.corp.intel.com> In-Reply-To: <3D3765A8CDB52A4C8B410430AA19CB236ECBD1F2@IRSMSX104.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMGM5Y2RlMTYtY2Q3Yi00NzhhLWJkODItY2Y0NjE3N2FlOWY3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6InlOWmllRVUzY3VpaHFneUhOaG9HVXJPMXF0QzA1b3ErejlKSWRodlJQbXc9In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] baseband/turbo_sw: update Turbo Software driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Apr 2018 07:37:49 -0000 Hi Amr, > -----Original Message----- > From: Mokhtar, Amr > Sent: Tuesday, April 24, 2018 7:53 PM > To: De Lara Guarch, Pablo ; Chalupnik, Ka= milX > ; dev@dpdk.org > Cc: Chalupnik, KamilX > Subject: RE: [dpdk-dev] [PATCH v2] baseband/turbo_sw: update Turbo Softwa= re > driver >=20 >=20 > > -----Original Message----- > > From: De Lara Guarch, Pablo > > Sent: Tuesday 24 April 2018 18:56 > > To: Chalupnik, KamilX ; dev@dpdk.org > > Cc: Mokhtar, Amr ; Chalupnik, KamilX > > > > Subject: RE: [dpdk-dev] [PATCH v2] baseband/turbo_sw: update Turbo > > Software driver > > > > > > > > > -----Original Message----- > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of KamilX > > > Chalupnik > > > Sent: Tuesday, April 17, 2018 3:44 PM > > > To: dev@dpdk.org > > > Cc: Mokhtar, Amr ; Chalupnik, KamilX > > > > > > Subject: [dpdk-dev] [PATCH v2] baseband/turbo_sw: update Turbo > > Software > > > driver > > > > > > Update Turbo Software driver for Wireless Baseband Device: > > > - support for optional CRC overlap in decode processing implemented > > > - function scaling input LLR values to specific range [-16, 16] > > > added > > > - sizes of the internal buffers used by decoding were increased due t= o > > > problem with memory for large test vectors > > > - new test vectors to check device capabilities added > > > > > > > Split this patch into multiple patches, each one doing a single item > > of your above list. > > Again, make sure that it can be compiled and that is functional along > > the patches. > > >=20 > Too much splits is a bit an overkill. > All the above changes are enhancements of Turbo coding operations. > They all fall under one common topic and appears like they are good to st= ay > combined in one patch. > The new test vectors are related to the added enhancements. I understand that they fall under the same top, that's why you should send = them in the same patchset. In DPDK, we aim at shorter patches (when possible), with are easier to review. We tend to avoid patches making multiple changes= , when they can be breakable (generally, when you have a list of changes in your commit= message, that means they should go into separate patches). Thanks, Pablo