From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 69504F90 for ; Wed, 25 Apr 2018 09:45:04 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Apr 2018 00:45:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,325,1520924400"; d="scan'208";a="44456823" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by FMSMGA003.fm.intel.com with ESMTP; 25 Apr 2018 00:45:02 -0700 Received: from irsmsx155.ger.corp.intel.com (163.33.192.3) by IRSMSX102.ger.corp.intel.com (163.33.3.155) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 25 Apr 2018 08:45:01 +0100 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.155]) by irsmsx155.ger.corp.intel.com ([169.254.14.143]) with mapi id 14.03.0319.002; Wed, 25 Apr 2018 08:45:01 +0100 From: "De Lara Guarch, Pablo" To: "Mokhtar, Amr" , "Chalupnik, KamilX" , "dev@dpdk.org" CC: "Chalupnik, KamilX" Thread-Topic: [dpdk-dev] [PATCH v2] baseband/turbo_sw: offload cost measurement test Thread-Index: AQHT1lh/uTSiYM8t+0Kod24sSbGByaQQHRiAgAAk5YCAAOH+UA== Date: Wed, 25 Apr 2018 07:45:01 +0000 Message-ID: References: <20180404140602.9344-2-kamilx.chalupnik@intel.com> <20180417142724.27748-1-kamilx.chalupnik@intel.com> <3D3765A8CDB52A4C8B410430AA19CB236ECBD232@IRSMSX104.ger.corp.intel.com> In-Reply-To: <3D3765A8CDB52A4C8B410430AA19CB236ECBD232@IRSMSX104.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNWFkZWI1NzItYzk2ZC00ZDAzLWEzYWEtZWE3YjJjM2UwZDAzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6Im1lN09MYmJtSXNVRVEyZkJ4Nm0zOSs0cmVIZUhBVkxWOWw5QVhHR3NuRXM9In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] baseband/turbo_sw: offload cost measurement test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Apr 2018 07:45:05 -0000 > -----Original Message----- > From: Mokhtar, Amr > Sent: Tuesday, April 24, 2018 8:09 PM > To: De Lara Guarch, Pablo ; Chalupnik, Ka= milX > ; dev@dpdk.org > Cc: Chalupnik, KamilX > Subject: RE: [dpdk-dev] [PATCH v2] baseband/turbo_sw: offload cost > measurement test >=20 >=20 >=20 > > -----Original Message----- > > From: De Lara Guarch, Pablo > > Sent: Tuesday 24 April 2018 18:45 > > To: Chalupnik, KamilX ; dev@dpdk.org > > Cc: Mokhtar, Amr ; Chalupnik, KamilX > > > > Subject: RE: [dpdk-dev] [PATCH v2] baseband/turbo_sw: offload cost > > measurement test > > > > > > > > > -----Original Message----- > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of KamilX > > > Chalupnik > > > Sent: Tuesday, April 17, 2018 3:27 PM > > > To: dev@dpdk.org > > > Cc: Mokhtar, Amr ; Chalupnik, KamilX > > > > > > Subject: [dpdk-dev] [PATCH v2] baseband/turbo_sw: offload cost > > measurement > > > test > > > > > > New test created to measure offload cost. > > > Changes were introduced in API, turbo software driver and test > > application. > > > > > > > Shouldn't this be generic to bbdev/baseband drivers in general and not > > just turbo? > > >=20 > Yes, it is generic. > But the only driver we have right now is the turbo_sw driver. Future driv= ers will > have a similar support. Right, then the title should be something like "bbdev: measure offload cost= ", since this is affecting multiple components in bbdev. >=20 > > > Signed-off-by: KamilX Chalupnik > > > > ... > > > > > --- a/lib/librte_bbdev/rte_bbdev.h > > > +++ b/lib/librte_bbdev/rte_bbdev.h > > > @@ -239,6 +239,10 @@ struct rte_bbdev_stats { > > > uint64_t enqueue_err_count; > > > /** Total error count on operations dequeued */ > > > uint64_t dequeue_err_count; > > > +#ifdef RTE_TEST_BBDEV > > > + /** It stores turbo decoder/encoder working time. */ > > > + uint64_t turbo_perf_time; > > > +#endif > > > > I don't think it is a good idea to use RTE_TEST_BBDEV here. > > This macro is used to enable/disable the compilation of the bbdev test > > app, so I think it should not be used in the API/PMDs. > > > > Also, this looks too specific for the Turbo SW PMD to be exposed as a > > generic statistic. >=20 > Well, it should be generic. Probably 'turbo' is a bad comment and name. > It's intention is to feedback execution time/cycles back to test app in o= rder to > collect the offload cost of the bbdev driver. > What is meant by the offload cost is the cycles consumed from the moment = of > enqueue till the moment the request is put on the acceleration engine inb= ound > sw ring (software) or MMIO operation (hardware). I understand. Then yes, probably you should find a better name, maybe offlo= ad_time? Thanks, Pablo