From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: "Chalupnik, KamilX" <kamilx.chalupnik@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Mokhtar, Amr" <amr.mokhtar@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] baseband/turbo_sw: optimization of turbo software driver
Date: Wed, 25 Apr 2018 10:00:51 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8976CCDCCA1@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <EEA9FF629BF25B47BD67ADE995041EE23CF5C650@IRSMSX103.ger.corp.intel.com>
Hi,
> -----Original Message-----
> From: Chalupnik, KamilX
> Sent: Wednesday, April 25, 2018 10:41 AM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; dev@dpdk.org
> Cc: Mokhtar, Amr <amr.mokhtar@intel.com>
> Subject: RE: [dpdk-dev] [PATCH v2] baseband/turbo_sw: optimization of turbo
> software driver
>
>
>
> > -----Original Message-----
> > From: De Lara Guarch, Pablo
> > Sent: Tuesday, April 24, 2018 7:54 PM
> > To: Chalupnik, KamilX <kamilx.chalupnik@intel.com>; dev@dpdk.org
> > Cc: Mokhtar, Amr <amr.mokhtar@intel.com>; Chalupnik, KamilX
> > <kamilx.chalupnik@intel.com>
> > Subject: RE: [dpdk-dev] [PATCH v2] baseband/turbo_sw: optimization of
> > turbo software driver
> >
> >
> >
> > > -----Original Message-----
> > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of KamilX
> > > Chalupnik
> > > Sent: Tuesday, April 17, 2018 3:34 PM
> > > To: dev@dpdk.org
> > > Cc: Mokhtar, Amr <amr.mokhtar@intel.com>; Chalupnik, KamilX
> > > <kamilx.chalupnik@intel.com>
> > > Subject: [dpdk-dev] [PATCH v2] baseband/turbo_sw: optimization of
> > > turbo software driver
> >
> > Optimization of the driver is not a good title, in my opinion.
> > Instead, call out what you are actually changing.
> > You should separate this patch into two patches, based on the two
> > bullet points below.
> >
>
> Ok, I will separate it and change the title.
>
> > >
> > > Optimization of Turbo Software driver:
> > > - resource-hungry piece of code removed or optimized
> > > - validation of decoder/encoder parameters put under debug flug
> > >
> >
> > ...
> >
> > >
> > > +#ifdef RTE_LIBRTE_BBDEV_DEBUG
> >
> > Where is this macro defined?
> > In DPDK we are avoiding the use of compile time options when possible,
> > so it is a better idea to use a runtime option to avoid the execution
> > of part of the code (passed through device configuration maybe?).
> > Otherwise, compilation checking gets more difficult.
> >
>
> It seems that I missed one change. I thought it was added in previous release
> RTE_LIBRTE_BBDEV_DEBUG will be defined in config/common_base.
> Are you ok with that?
These kind of compilation flags are not accepted in DPDK anymore,
as they hide compilation issues.
If you want to have a different path for debugging, you should use run-time flags,
passed to the device configuration (I'd say through devargs).
Thanks,
Pablo
next prev parent reply other threads:[~2018-04-25 10:00 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-04 14:05 [dpdk-dev] [PATCH] doc: update bbdev library documentation KamilX Chalupnik
2018-04-04 14:05 ` [dpdk-dev] [PATCH] baseband/turbo_sw: offload cost measurement test KamilX Chalupnik
2018-04-13 23:18 ` Mokhtar, Amr
2018-04-13 23:37 ` Mokhtar, Amr
2018-04-17 14:27 ` [dpdk-dev] [PATCH v2] " KamilX Chalupnik
2018-04-17 16:50 ` Mokhtar, Amr
2018-04-24 17:44 ` De Lara Guarch, Pablo
2018-04-24 19:09 ` Mokhtar, Amr
2018-04-25 7:45 ` De Lara Guarch, Pablo
2018-04-04 14:05 ` [dpdk-dev] [PATCH] baseband/turbo_sw: optimization of turbo software driver KamilX Chalupnik
2018-04-13 19:56 ` Mokhtar, Amr
2018-04-17 14:34 ` [dpdk-dev] [PATCH v2] " KamilX Chalupnik
2018-04-17 16:55 ` Mokhtar, Amr
2018-04-24 17:53 ` De Lara Guarch, Pablo
[not found] ` <EEA9FF629BF25B47BD67ADE995041EE23CF5C650@IRSMSX103.ger.corp.intel.com>
2018-04-25 10:00 ` De Lara Guarch, Pablo [this message]
2018-04-04 14:05 ` [dpdk-dev] [PATCH] baseband/turbo_sw: splitting Queue Groups KamilX Chalupnik
2018-04-13 23:19 ` Mokhtar, Amr
2018-04-17 14:39 ` [dpdk-dev] [PATCH v2] " KamilX Chalupnik
2018-04-17 16:55 ` Mokhtar, Amr
2018-04-24 15:30 ` De Lara Guarch, Pablo
2018-04-24 17:20 ` De Lara Guarch, Pablo
2018-04-04 14:05 ` [dpdk-dev] [PATCH] baseband/turbo_sw: update Turbo Software driver KamilX Chalupnik
2018-04-13 19:58 ` Mokhtar, Amr
2018-04-17 14:43 ` [dpdk-dev] [PATCH v2] " KamilX Chalupnik
2018-04-17 16:56 ` Mokhtar, Amr
2018-04-19 14:31 ` De Lara Guarch, Pablo
2018-04-24 17:55 ` De Lara Guarch, Pablo
2018-04-24 18:53 ` Mokhtar, Amr
2018-04-25 7:37 ` De Lara Guarch, Pablo
2018-04-04 14:06 ` [dpdk-dev] [PATCH] app/bbdev: remove improper WARNING printouts KamilX Chalupnik
2018-04-13 23:20 ` Mokhtar, Amr
2018-04-18 9:26 ` [dpdk-dev] [PATCH v2] " KamilX Chalupnik
2018-04-18 14:16 ` Mokhtar, Amr
2018-04-24 14:10 ` De Lara Guarch, Pablo
2018-04-04 14:06 ` [dpdk-dev] [PATCH] app/bbdev: update test vectors KamilX Chalupnik
2018-04-13 23:22 ` Mokhtar, Amr
2018-04-24 14:56 ` De Lara Guarch, Pablo
2018-04-24 15:41 ` Mokhtar, Amr
2018-04-04 14:06 ` [dpdk-dev] [PATCH] app/bbdev: dynamic lib support KamilX Chalupnik
2018-04-17 17:01 ` Mokhtar, Amr
2018-04-24 14:18 ` De Lara Guarch, Pablo
[not found] ` <EEA9FF629BF25B47BD67ADE995041EE23CF5B5C4@IRSMSX103.ger.corp.intel.com>
2018-04-25 16:10 ` De Lara Guarch, Pablo
[not found] ` <EEA9FF629BF25B47BD67ADE995041EE23CF5DBFE@IRSMSX103.ger.corp.intel.com>
2018-04-26 9:47 ` De Lara Guarch, Pablo
2018-04-26 11:28 ` De Lara Guarch, Pablo
[not found] ` <EEA9FF629BF25B47BD67ADE995041EE23CF5DD78@IRSMSX103.ger.corp.intel.com>
2018-04-26 13:22 ` De Lara Guarch, Pablo
[not found] ` <EEA9FF629BF25B47BD67ADE995041EE23CF5DE21@IRSMSX103.ger.corp.intel.com>
2018-04-26 14:29 ` De Lara Guarch, Pablo
2018-04-13 19:30 ` [dpdk-dev] [PATCH] doc: update bbdev library documentation Mokhtar, Amr
2018-04-19 14:29 ` De Lara Guarch, Pablo
2018-04-22 20:17 ` Thomas Monjalon
2018-04-23 10:24 ` De Lara Guarch, Pablo
2018-04-23 10:56 ` Mokhtar, Amr
2018-04-23 11:12 ` Thomas Monjalon
2018-04-23 12:15 ` Mokhtar, Amr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8976CCDCCA1@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=amr.mokhtar@intel.com \
--cc=dev@dpdk.org \
--cc=kamilx.chalupnik@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).