From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id D8BD44C99 for ; Wed, 25 Apr 2018 12:00:54 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Apr 2018 03:00:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,325,1520924400"; d="scan'208";a="194243927" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by orsmga004.jf.intel.com with ESMTP; 25 Apr 2018 03:00:52 -0700 Received: from irsmsx111.ger.corp.intel.com (10.108.20.4) by IRSMSX152.ger.corp.intel.com (163.33.192.66) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 25 Apr 2018 11:00:52 +0100 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.155]) by irsmsx111.ger.corp.intel.com ([169.254.2.167]) with mapi id 14.03.0319.002; Wed, 25 Apr 2018 11:00:52 +0100 From: "De Lara Guarch, Pablo" To: "Chalupnik, KamilX" , "dev@dpdk.org" CC: "Mokhtar, Amr" Thread-Topic: [dpdk-dev] [PATCH v2] baseband/turbo_sw: optimization of turbo software driver Thread-Index: AQHT1llqnUW7PtFkFUe45q4OXbv5TqQQO/uwgAD5hQCAABJzoA== Date: Wed, 25 Apr 2018 10:00:51 +0000 Message-ID: References: <20180404140602.9344-3-kamilx.chalupnik@intel.com> <20180417143408.3520-1-kamilx.chalupnik@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjdkODNlMmYtOWI4My00M2NhLThhOGUtYzRjMzc3ZGYzNjlhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IlRyS3FmN0pSRG8xa1pkaDdxTkUxbTdhcmJcL2E2TXlHdXkrU2I0blwvYlB6az0ifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] baseband/turbo_sw: optimization of turbo software driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Apr 2018 10:00:55 -0000 Hi, > -----Original Message----- > From: Chalupnik, KamilX > Sent: Wednesday, April 25, 2018 10:41 AM > To: De Lara Guarch, Pablo ; dev@dpdk.org > Cc: Mokhtar, Amr > Subject: RE: [dpdk-dev] [PATCH v2] baseband/turbo_sw: optimization of tur= bo > software driver >=20 >=20 >=20 > > -----Original Message----- > > From: De Lara Guarch, Pablo > > Sent: Tuesday, April 24, 2018 7:54 PM > > To: Chalupnik, KamilX ; dev@dpdk.org > > Cc: Mokhtar, Amr ; Chalupnik, KamilX > > > > Subject: RE: [dpdk-dev] [PATCH v2] baseband/turbo_sw: optimization of > > turbo software driver > > > > > > > > > -----Original Message----- > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of KamilX > > > Chalupnik > > > Sent: Tuesday, April 17, 2018 3:34 PM > > > To: dev@dpdk.org > > > Cc: Mokhtar, Amr ; Chalupnik, KamilX > > > > > > Subject: [dpdk-dev] [PATCH v2] baseband/turbo_sw: optimization of > > > turbo software driver > > > > Optimization of the driver is not a good title, in my opinion. > > Instead, call out what you are actually changing. > > You should separate this patch into two patches, based on the two > > bullet points below. > > >=20 > Ok, I will separate it and change the title. >=20 > > > > > > Optimization of Turbo Software driver: > > > - resource-hungry piece of code removed or optimized > > > - validation of decoder/encoder parameters put under debug flug > > > > > > > ... > > > > > > > > +#ifdef RTE_LIBRTE_BBDEV_DEBUG > > > > Where is this macro defined? > > In DPDK we are avoiding the use of compile time options when possible, > > so it is a better idea to use a runtime option to avoid the execution > > of part of the code (passed through device configuration maybe?). > > Otherwise, compilation checking gets more difficult. > > >=20 > It seems that I missed one change. I thought it was added in previous rel= ease > RTE_LIBRTE_BBDEV_DEBUG will be defined in config/common_base. > Are you ok with that? These kind of compilation flags are not accepted in DPDK anymore, as they hide compilation issues. If you want to have a different path for debugging, you should use run-time= flags, passed to the device configuration (I'd say through devargs). Thanks, Pablo