From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 6E60E8DA5 for ; Wed, 25 Apr 2018 18:10:46 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Apr 2018 09:10:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,326,1520924400"; d="scan'208";a="219316492" Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by orsmga005.jf.intel.com with ESMTP; 25 Apr 2018 09:10:43 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.155]) by IRSMSX106.ger.corp.intel.com ([169.254.8.37]) with mapi id 14.03.0319.002; Wed, 25 Apr 2018 17:10:42 +0100 From: "De Lara Guarch, Pablo" To: "Chalupnik, KamilX" , "dev@dpdk.org" CC: "Mokhtar, Amr" Thread-Topic: [dpdk-dev] [PATCH] app/bbdev: dynamic lib support Thread-Index: AQHTzB5WbYdJWBOtYEmRu+DkPJ1VhaQQFMBggAElHYCAAIobMA== Date: Wed, 25 Apr 2018 16:10:42 +0000 Message-ID: References: <20180404140602.9344-1-kamilx.chalupnik@intel.com> <20180404140602.9344-8-kamilx.chalupnik@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZmExZmI5NDItNTI4Yi00YzdhLWJkZDEtZjdkYTNlOWM1ZmNlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6Ijl0bUt6QUpuTUM1djJ5QzVcL3d1RlA3emcySFlrMmFxNit1UWdNOHFBeUowPSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] app/bbdev: dynamic lib support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Apr 2018 16:10:47 -0000 Hi Kamil, > -----Original Message----- > From: Chalupnik, KamilX > Sent: Wednesday, April 25, 2018 9:43 AM > To: De Lara Guarch, Pablo ; dev@dpdk.org > Cc: Mokhtar, Amr > Subject: RE: [dpdk-dev] [PATCH] app/bbdev: dynamic lib support >=20 > Hi Pablo >=20 > > -----Original Message----- > > From: De Lara Guarch, Pablo > > Sent: Tuesday, April 24, 2018 4:18 PM > > To: Chalupnik, KamilX ; dev@dpdk.org > > Cc: Mokhtar, Amr ; Chalupnik, KamilX > > > > Subject: RE: [dpdk-dev] [PATCH] app/bbdev: dynamic lib support > > > > Hi Kamil, > > > > > -----Original Message----- > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of KamilX > > > Chalupnik > > > Sent: Wednesday, April 4, 2018 3:06 PM > > > To: dev@dpdk.org > > > Cc: Mokhtar, Amr ; Chalupnik, KamilX > > > > > > Subject: [dpdk-dev] [PATCH] app/bbdev: dynamic lib support > > > > > > From: "Chalupnik, KamilX" > > > > > > Support for linking with dynamic library added in Baseband Device > > > test application > > > > > > Signed-off-by: KamilX Chalupnik > > > --- > > > app/test-bbdev/Makefile | 4 ++++ > > > doc/guides/tools/testbbdev.rst | 7 +++++++ > > > 2 files changed, 11 insertions(+) > > > > > > diff --git a/app/test-bbdev/Makefile b/app/test-bbdev/Makefile index > > > 6da0c8e..26c9a4b 100644 > > > --- a/app/test-bbdev/Makefile > > > +++ b/app/test-bbdev/Makefile > > > @@ -22,4 +22,8 @@ SRCS-$(CONFIG_RTE_TEST_BBDEV) +=3D > > test_bbdev_vector.c > > > > > > LDLIBS +=3D -lm > > > > > > +ifeq ($(CONFIG_RTE_LIBRTE_PMD_BBDEV_TURBO_SW),y) > > > +LDLIBS +=3D -lrte_pmd_bbdev_turbo_sw > > > +endif > > > > This is already done in mk/rte.app.mk, so it should not be needed. > > >=20 > We need this here when DPDK is built as dynamic library. > In rte.app.mk lrte_pmd_bbdev_turbo_sw is added to LDLIBS when > CONFIG_RTE_BUILD_SHARED_LIB is not set. In that case, you need to use the EAL option "-d" with the .so library. ./testbbdev -d build/lib/librte_pmd_bbdev_turbo_sw.so --vdev=3D"turbo_sw" Btw, now that I have seen the name of the vdev, I think you should rename t= o "baseband_turbo_sw". Also, NULL PMD should be renamed to "baseband_null". Thanks, Pablo