From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 251657CFF for ; Thu, 26 Apr 2018 16:29:48 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Apr 2018 07:29:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,330,1520924400"; d="scan'208";a="53853985" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by orsmga002.jf.intel.com with ESMTP; 26 Apr 2018 07:29:47 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.155]) by IRSMSX102.ger.corp.intel.com ([169.254.2.83]) with mapi id 14.03.0319.002; Thu, 26 Apr 2018 15:29:46 +0100 From: "De Lara Guarch, Pablo" To: "Chalupnik, KamilX" , "dev@dpdk.org" CC: "Mokhtar, Amr" Thread-Topic: [dpdk-dev] [PATCH] app/bbdev: dynamic lib support Thread-Index: AQHTzB5WbYdJWBOtYEmRu+DkPJ1VhaQQFMBggAElHYCAAIobMIABGKqAgAAt3lCAAAY3AIAAGR0wgAABk4CAABGxoA== Date: Thu, 26 Apr 2018 14:29:45 +0000 Message-ID: References: <20180404140602.9344-1-kamilx.chalupnik@intel.com> <20180404140602.9344-8-kamilx.chalupnik@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZmQ4Y2FmNmItMTgzNS00ZDg1LTgwMzMtOTQwOTFkYTcyYjMwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6Ink1cm5KZ3d1cml2VWtzYmppTzFuUndyTElBWXhtZkN0NjhWb0lzSVBrUlE9In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] app/bbdev: dynamic lib support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Apr 2018 14:29:49 -0000 > -----Original Message----- > From: Chalupnik, KamilX > Sent: Thursday, April 26, 2018 3:24 PM > To: De Lara Guarch, Pablo ; dev@dpdk.org > Cc: Mokhtar, Amr > Subject: RE: [dpdk-dev] [PATCH] app/bbdev: dynamic lib support >=20 > Hi Pablo >=20 > > -----Original Message----- > > From: De Lara Guarch, Pablo > > Sent: Thursday, April 26, 2018 3:22 PM > > To: Chalupnik, KamilX ; dev@dpdk.org > > Cc: Mokhtar, Amr > > Subject: RE: [dpdk-dev] [PATCH] app/bbdev: dynamic lib support > > > > > > > > > -----Original Message----- > > > From: Chalupnik, KamilX > > > Sent: Thursday, April 26, 2018 1:48 PM > > > To: De Lara Guarch, Pablo ; > > > dev@dpdk.org > > > Cc: Mokhtar, Amr > > > Subject: RE: [dpdk-dev] [PATCH] app/bbdev: dynamic lib support > > > > > > Hi Pablo > > > > > > > ... > > > > > > > Ok, we will deliver such changes in patches for next release. > > > > > Are you ok with that? > > > > > > > > I think this change should not take a long time. The sooner we do > > > > it, the better, as there might be more people using this in the fut= ure. > > > > I can send the patch for you, so you can focus on other changes, > > > > and then you can see if it is fine for you. > > > > > > > > Thanks, > > > > Pablo > > > > > > Ok. I will add this change to our patchset as well. > > > > In order to make sure that users can still use the previous name, to > > avoid breaking Backwards compatibility, you modify DRIVER_NAME with > > the new name and then use RTE_PMD_REGISTER_ALIAS(DRIVER_NAME, > > turbo_sw); This way, both names can be used, but you should update the > > docs to use the new name. > > > > Thanks, > > Pablo >=20 >=20 > Thanks for suggestions :) > I've already prepared a changes. Just one question. Can I prepare separat= e patch > based on the 13 patchset? Is that ok? Such solution will be cleaner in my= opinion. >=20 Sure, this change should be independent from the other ones. You don't have= to add all patches in the same patchset (when they are not logically relat= ed). Thanks, Pablo > Best regards, > Kamil >=20