From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 11D8E2E41 for ; Mon, 7 May 2018 15:29:25 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 May 2018 06:29:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,374,1520924400"; d="scan'208";a="37432168" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by fmsmga007.fm.intel.com with ESMTP; 07 May 2018 06:29:23 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.150]) by IRSMSX152.ger.corp.intel.com ([169.254.6.199]) with mapi id 14.03.0319.002; Mon, 7 May 2018 14:29:22 +0100 From: "De Lara Guarch, Pablo" To: "Chalupnik, KamilX" , "dev@dpdk.org" CC: "Mokhtar, Amr" Thread-Topic: [PATCH 09/13] bbdev: measure offload cost Thread-Index: AQHT3WMUWcfuwlx6rUmlijGuQJ9ESKQkUQ3g Date: Mon, 7 May 2018 13:29:21 +0000 Message-ID: References: <20180426133008.12388-1-kamilx.chalupnik@intel.com> <20180426133008.12388-9-kamilx.chalupnik@intel.com> In-Reply-To: <20180426133008.12388-9-kamilx.chalupnik@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTQ3ZDBhYTItNDIyOS00YmIwLTg2MTAtMjYzOTVkNmI5MjMyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IlZDaUNHYWJpcXYzNWV5WFVFT0lKV3BFN2RoQTlkZENGdDh5aVp4S2VkTjg9In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 09/13] bbdev: measure offload cost X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 May 2018 13:29:26 -0000 > -----Original Message----- > From: Chalupnik, KamilX > Sent: Thursday, April 26, 2018 2:30 PM > To: dev@dpdk.org > Cc: Mokhtar, Amr ; De Lara Guarch, Pablo > ; Chalupnik, KamilX > > Subject: [PATCH 09/13] bbdev: measure offload cost >=20 ... > --- a/lib/librte_bbdev/rte_bbdev.h > +++ b/lib/librte_bbdev/rte_bbdev.h > @@ -239,6 +239,10 @@ struct rte_bbdev_stats { > uint64_t enqueue_err_count; > /** Total error count on operations dequeued */ > uint64_t dequeue_err_count; > +#ifdef RTE_TEST_BBDEV > + /** It stores offload time. */ Just "offload time" is fine. > + uint64_t offload_time; > +#endif Again, I don't think it is a good idea to have this compilation check. RTE_TEST_BBDEV is used to enable the compilation of the test app, so it shouldn't be used for anything else. Also, in DPDK, we are avoiding the usage of this conditionals to enable/dis= able pieces of code. If you want to avoid the computation of this time, add a configuration opti= on in bbdev configuration structure (rte_bbdev_queue_conf?), so the decision i= s made at runtime. > }; >=20 > /** > -- > 2.5.5