DPDK patches and discussions
 help / color / mirror / Atom feed
From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: "Kumar, Ravi1" <Ravi1.Kumar@amd.com>,
	Thomas Monjalon <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>
Subject: Re: [dpdk-dev] [PATCH 1/2] crypto/ccp: enable CCP crypto poll mode driver by default
Date: Wed, 9 May 2018 08:36:21 +0000	[thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8976CD04BFD@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <CY4PR12MB1509039BE3293E922D0C579BAE990@CY4PR12MB1509.namprd12.prod.outlook.com>

Hi Ravi,

> -----Original Message-----
> From: Kumar, Ravi1 [mailto:Ravi1.Kumar@amd.com]
> Sent: Wednesday, May 9, 2018 9:11 AM
> To: Thomas Monjalon <thomas@monjalon.net>
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; dev@dpdk.org;
> hemant.agrawal@nxp.com
> Subject: RE: [PATCH 1/2] crypto/ccp: enable CCP crypto poll mode driver by
> default
> 
> >09/05/2018 07:53, Kumar, Ravi1:
> >> >
> >> >I think this cannot be enabled by default, since it has an external
> dependency on OpenSSL.
> >>
> >> Hi Pablo,
> >>
> >> We were asked to enable the PMD by default in one of the previous emails.
> Unfortunately, we can't remove the dependency on OpenSSL. Kindly suggest the
> option in this case. We could leave this patch-set and have the code as-is, I
> mean the older compile-time option. If not, then this is our only option.
> >
> >If you have a dependency, you cannot enable by default.
> >
> Hi Thomas,
> 
> Ok. Could we still submit the 2nd patch for changing compile time to run time
> option and remove the first one?

I have two comments on the other patch. Could you submit a v2 of that patch and drop this first patch?

Thanks,
Pablo

> 
> Regards,
> Ravi

  parent reply	other threads:[~2018-05-09  8:36 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-03  5:57 Ravi Kumar
2018-05-03  5:57 ` [dpdk-dev] [PATCH 2/2] crypto/ccp: change to command line option from compile time Ravi Kumar
2018-05-09  8:34   ` De Lara Guarch, Pablo
2018-05-03  7:23 ` [dpdk-dev] [PATCH 1/2] crypto/ccp: enable CCP crypto poll mode driver by default De Lara Guarch, Pablo
2018-05-09  5:53   ` Kumar, Ravi1
2018-05-09  7:58     ` Thomas Monjalon
2018-05-09  8:11       ` Kumar, Ravi1
2018-05-09  8:19         ` Thomas Monjalon
2018-05-09  8:36         ` De Lara Guarch, Pablo [this message]
2018-05-09  8:58           ` Kumar, Ravi1
2018-05-09 12:46 ` [dpdk-dev] [PATCH v2] crypto/ccp: support command line option to enable CPU based auth Ravi Kumar
2018-05-09 15:27   ` De Lara Guarch, Pablo
2018-05-10  8:43     ` Kumar, Ravi1
2018-05-10  8:46       ` De Lara Guarch, Pablo
2018-05-10  9:20   ` [dpdk-dev] [PATCH v3] " Ravi Kumar
2018-05-10 12:22     ` De Lara Guarch, Pablo
2018-05-11  5:37       ` Kumar, Ravi1

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8976CD04BFD@IRSMSX108.ger.corp.intel.com \
    --to=pablo.de.lara.guarch@intel.com \
    --cc=Ravi1.Kumar@amd.com \
    --cc=dev@dpdk.org \
    --cc=hemant.agrawal@nxp.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).