From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 946B88E5F for ; Wed, 9 May 2018 10:36:24 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 May 2018 01:36:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,381,1520924400"; d="scan'208";a="57155812" Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23]) by orsmga002.jf.intel.com with ESMTP; 09 May 2018 01:36:22 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.150]) by IRSMSX109.ger.corp.intel.com ([169.254.13.176]) with mapi id 14.03.0319.002; Wed, 9 May 2018 09:36:21 +0100 From: "De Lara Guarch, Pablo" To: "Kumar, Ravi1" , Thomas Monjalon CC: "dev@dpdk.org" , "hemant.agrawal@nxp.com" Thread-Topic: [PATCH 1/2] crypto/ccp: enable CCP crypto poll mode driver by default Thread-Index: AQHT4qOzsMWnnWWcPUOes769Y9uzXKQdmbEAgAlEgYCAACKoAIAAA6cAgAAXk/A= Date: Wed, 9 May 2018 08:36:21 +0000 Message-ID: References: <1525327041-128382-1-git-send-email-Ravi1.kumar@amd.com> <12839818.NQYkpLnXHL@xps> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjQzYmVjNzktNzhlOS00MWI3LWExY2MtZGI4NTEwOTk0ZmZjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6InY5WVJMYkVlOVFjbzM0VkxITkVFODUzcEJaVWZSd2NJUW9BVnFcLzVOeGo4PSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 1/2] crypto/ccp: enable CCP crypto poll mode driver by default X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 May 2018 08:36:25 -0000 Hi Ravi, > -----Original Message----- > From: Kumar, Ravi1 [mailto:Ravi1.Kumar@amd.com] > Sent: Wednesday, May 9, 2018 9:11 AM > To: Thomas Monjalon > Cc: De Lara Guarch, Pablo ; dev@dpdk.org; > hemant.agrawal@nxp.com > Subject: RE: [PATCH 1/2] crypto/ccp: enable CCP crypto poll mode driver b= y > default >=20 > >09/05/2018 07:53, Kumar, Ravi1: > >> > > >> >I think this cannot be enabled by default, since it has an external > dependency on OpenSSL. > >> > >> Hi Pablo, > >> > >> We were asked to enable the PMD by default in one of the previous emai= ls. > Unfortunately, we can't remove the dependency on OpenSSL. Kindly suggest = the > option in this case. We could leave this patch-set and have the code as-i= s, I > mean the older compile-time option. If not, then this is our only option. > > > >If you have a dependency, you cannot enable by default. > > > Hi Thomas, >=20 > Ok. Could we still submit the 2nd patch for changing compile time to run = time > option and remove the first one? I have two comments on the other patch. Could you submit a v2 of that patch= and drop this first patch? Thanks, Pablo >=20 > Regards, > Ravi