From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id E0C701B6E0 for ; Wed, 9 May 2018 17:27:59 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 May 2018 08:27:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,382,1520924400"; d="scan'208";a="53745584" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by fmsmga001.fm.intel.com with ESMTP; 09 May 2018 08:27:57 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.150]) by IRSMSX101.ger.corp.intel.com ([169.254.1.118]) with mapi id 14.03.0319.002; Wed, 9 May 2018 16:27:56 +0100 From: "De Lara Guarch, Pablo" To: Ravi Kumar , "dev@dpdk.org" CC: "thomas@monjalon.net" , "hemant.agrawal@nxp.com" Thread-Topic: [PATCH v2] crypto/ccp: support command line option to enable CPU based auth Thread-Index: AQHT55PyPb65byrnIEuiDA7nf6tGfqQng2Eg Date: Wed, 9 May 2018 15:27:56 +0000 Message-ID: References: <1525327041-128382-1-git-send-email-Ravi1.kumar@amd.com> <1525869983-4705-1-git-send-email-Ravi1.kumar@amd.com> In-Reply-To: <1525869983-4705-1-git-send-email-Ravi1.kumar@amd.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzllMmRmM2MtYmYwOC00ZTEyLWI3MjYtZjkwYWM4M2QzNmUxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6ImRiXC9kUWFHcnBXazVkYTlkMFJObzlqQ3BYNEN0YWpMQU91NkJaR0pkVytzPSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] crypto/ccp: support command line option to enable CPU based auth X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 May 2018 15:28:00 -0000 Hi Ravi, > -----Original Message----- > From: Ravi Kumar [mailto:Ravi1.kumar@amd.com] > Sent: Wednesday, May 9, 2018 1:46 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; > thomas@monjalon.net; hemant.agrawal@nxp.com > Subject: [PATCH v2] crypto/ccp: support command line option to enable CPU > based auth >=20 > CCP PMD supports authentication offload to either of CCP or CPU. > The earlier version of patch provides this option as compile time. > This patch changes this option from compile time to run time. > User can pass "ccp_auth_opt=3D1" as an additional arguments to vdev > parameter to enable authentication operations on CPU. >=20 > Signed-off-by: Ravi Kumar ... > RTE_PMD_REGISTER_VDEV(CRYPTODEV_NAME_CCP_PMD, > cryptodev_ccp_pmd_drv); > RTE_PMD_REGISTER_PARAM_STRING(CRYPTODEV_NAME_CCP_PMD, > - "max_nb_queue_pairs=3D max_nb_sessions=3D socket_id=3D")= ; > + "max_nb_queue_pairs=3D " > + "max_nb_sessions=3D " > + "socket_id=3D " > + "ccp_auth_opt=3D"); Die_num is not in this list. I was going to add it myself, but then I realized that it is not actually used anywhere. Am I missing something? Also, I think it is worth updating the documentation of the PMD with these = parameters. Thanks, Pablo