From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "thomas@monjalon.net" <thomas@monjalon.net>,
"andy@warmcat.com" <andy@warmcat.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] examples/quota_watermark: fix wrong function type casing
Date: Thu, 10 May 2018 09:32:53 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8976CD065E3@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <20180510090431.15305-1-jerin.jacob@caviumnetworks.com>
Hi Jerin,
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jerin Jacob
> Sent: Thursday, May 10, 2018 10:05 AM
> To: dev@dpdk.org
> Cc: thomas@monjalon.net; andy@warmcat.com; Jerin Jacob
> <jerin.jacob@caviumnetworks.com>; Richardson, Bruce
> <bruce.richardson@intel.com>; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] examples/quota_watermark: fix wrong function
> type casing
>
> make pipeline_stage() and send_stage() as lcore_function_t.
> Found this issue with gcc 8.1.
>
> examples/quota_watermark/qw/main.c: In function ‘main’:
> examples/quota_watermark/qw/main.c:350:26: error: cast between
> incompatible function types from ‘void (*)(void *)’ to ‘int (*)(void *)’ [-
> Werror=cast-function-type] rte_eal_remote_launch((int (*)(void
> *))pipeline_stage,
> ^
> examples/quota_watermark/qw/main.c:357:24: error: cast between
> incompatible function types from ‘void (*)(void *)’ to ‘int (*)(void *)’ [-
> Werror=cast-function-type] rte_eal_remote_launch((int (*)(void *))send_stage,
> NULL, last_lcore_id);
>
> Cc: bruce.richardson@intel.com
> Cc: stable@dpdk.org
>
> Fixes: 1d6c3ee3321a ("examples/quota_watermark: initial import")
There is already a fix for this:
http://dpdk.org/dev/patchwork/patch/39564/
prev parent reply other threads:[~2018-05-10 9:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-10 9:04 Jerin Jacob
2018-05-10 9:32 ` De Lara Guarch, Pablo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8976CD065E3@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=andy@warmcat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).