From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id AB3661BB67 for ; Thu, 10 May 2018 17:52:58 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 May 2018 08:52:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,385,1520924400"; d="scan'208";a="53190972" Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25]) by fmsmga004.fm.intel.com with ESMTP; 10 May 2018 08:52:56 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.150]) by irsmsx110.ger.corp.intel.com ([169.254.15.125]) with mapi id 14.03.0319.002; Thu, 10 May 2018 16:52:55 +0100 From: "De Lara Guarch, Pablo" To: "Gujjar, Abhinandan S" , "jerin.jacob@caviumnetworks.com" , "hemant.agrawal@nxp.com" , "akhil.goyal@nxp.com" , "dev@dpdk.org" CC: "Vangati, Narender" , "Gujjar, Abhinandan S" , "Rao, Nikhil" , "Eads, Gage" Thread-Topic: [dpdk-dev] [v5,4/5] test: add event crypto adapter auto-test Thread-Index: AQHT525T09o66bJo70C1iGwQUn7te6QpHerg Date: Thu, 10 May 2018 15:52:55 +0000 Message-ID: References: <1525853881-140647-1-git-send-email-abhinandan.gujjar@intel.com> <1525853881-140647-5-git-send-email-abhinandan.gujjar@intel.com> In-Reply-To: <1525853881-140647-5-git-send-email-abhinandan.gujjar@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjZiMzdhOTUtZTIwYS00MDIzLTgzZjQtMDJiZjE3NjYyYWE4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6ImxnaE9za0poZThGTU9zNmd0Y1hWYWdUU2ZJWFYwUFV4Q29FU0xQVDlTVUU9In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [v5,4/5] test: add event crypto adapter auto-test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 May 2018 15:53:00 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Abhinandan Gujjar > Sent: Wednesday, May 9, 2018 9:18 AM > To: jerin.jacob@caviumnetworks.com; hemant.agrawal@nxp.com; > akhil.goyal@nxp.com; dev@dpdk.org > Cc: Vangati, Narender ; Gujjar, Abhinandan S > ; Rao, Nikhil ; Eads, = Gage > > Subject: [dpdk-dev] [v5,4/5] test: add event crypto adapter auto-test >=20 > Added testsuite to test the crypto adapter functionality. > The testsuite detects the HW/SW event & crypto devices and their capabili= ties. > Depending upon the capability, adapter is confgured and modes are tested. >=20 > Signed-off-by: Abhinandan Gujjar > Acked-by: Akhil Goyal ... > + /* > + * Create mempool with maximum number of sessions * 2, > + * to include the session headers & private data > + */ > + session_size =3D rte_cryptodev_get_private_session_size(TEST_CDEV_ID); > + session_size +=3D sizeof(union rte_event_crypto_metadata); > + > + params.session_mpool =3D rte_mempool_create( > + "CRYPTO_ADAPTER_SESSION_MP", > + info.sym.max_nb_sessions * 2, > + session_size, > + 0, 0, NULL, NULL, NULL, > + NULL, SOCKET_ID_ANY, > + 0); I am seeing an icc compilation issue here: test/test/test_event_crypto_adapter.c(530): error #592: variable "info" is = used before its v = alue is set info.sym.max_nb_sessions * 2, Looking at this, info gets filled below, after using it in mempool_create, = which looks wrong. But also, keep in mind that we are going to remove max_nb_sessions, since this was used when the session pool was created inside the PMD. I suggest to set your own number of session in the test and not use max_nb_= sessions. Thanks, Pablo