From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pablo.de.lara.guarch@intel.com>
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
by dpdk.org (Postfix) with ESMTP id 14E1D1B1BD;
Wed, 16 May 2018 14:50:13 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
16 May 2018 05:50:12 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.49,404,1520924400"; d="scan'208";a="49708674"
Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59])
by FMSMGA003.fm.intel.com with ESMTP; 16 May 2018 05:50:11 -0700
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.150]) by
IRSMSX151.ger.corp.intel.com ([169.254.4.167]) with mapi id 14.03.0319.002;
Wed, 16 May 2018 13:50:10 +0100
From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: "thomas@monjalon.net" <thomas@monjalon.net>, "Doherty, Declan"
<declan.doherty@intel.com>, "andy@warmcat.com" <andy@warmcat.com>,
"stable@dpdk.org" <stable@dpdk.org>
Thread-Topic: [dpdk-dev] [PATCH v2 2/2] app/crypto-perf: fix memcpy source
Thread-Index: AQHT7RFsIwWxaPlIh0mxZVJCNIu2HaQyTqAg
Date: Wed, 16 May 2018 12:50:10 +0000
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8976CD0C487@IRSMSX108.ger.corp.intel.com>
References: <20180516063955.6193-1-jerin.jacob@caviumnetworks.com>
<20180516122804.535-1-jerin.jacob@caviumnetworks.com>
<20180516122804.535-2-jerin.jacob@caviumnetworks.com>
In-Reply-To: <20180516122804.535-2-jerin.jacob@caviumnetworks.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMmM3MjViYjMtYWU1OC00MWM5LWJhMjYtYTgwNzg0YWRkOWUzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IjFtZ0VGY29oNHQxblcxUE5KZXlPRzY3Z29qOTZBMXVZaVh5QW4xa2ZKT0U9In0=
x-ctpclassification: CTP_NT
dlp-product: dlpe-windows
dlp-version: 11.0.200.100
dlp-reaction: no-action
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v2 2/2] app/crypto-perf: fix memcpy source
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 16 May 2018 12:50:14 -0000
> -----Original Message-----
> From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com]
> Sent: Wednesday, May 16, 2018 1:28 PM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> thomas@monjalon.net; Jerin Jacob <jerin.jacob@caviumnetworks.com>;
> Doherty, Declan <declan.doherty@intel.com>; andy@warmcat.com;
> stable@dpdk.org
> Subject: [dpdk-dev] [PATCH v2 2/2] app/crypto-perf: fix memcpy source
>=20
> Since arm64 was using plain memcpy for rte_memcpy, gcc 8.1, could detect =
size
> was more than source address range. In this case, the source was wrong.
>=20
> /export/dpdk.org/test/test/test_cryptodev.c: In function
> 'test_multi_session_random_usage':
> /export/dpdk.org/build/include/rte_memcpy_64.h:364:29: error: 'memcpy'
> forming offset [113, 184] is out of the bounds [0, 112] of object
> 'testsuite_params' with type 'struct crypto_testsuite_params'
> [-Werror=3Darray-bounds]
> #define rte_memcpy(d, s, n) memcpy((d), (s), (n))
> ^~~~~~~~~~~~~~~~~~~~~
> /export/dpdk.org/test/test/test_cryptodev.c:6618:3: note: in expansion of
> macro 'rte_memcpy'
> rte_memcpy(&ut_paramz[i].ut_params, &testsuite_params,
> ^~~~~~~~~~
> /export/dpdk.org/test/test/test_cryptodev.c:140:39: note:
> 'testsuite_params' declared here
> static struct crypto_testsuite_params testsuite_params =3D { NULL };
>=20
> Fixes: ffbe3be0d4b5 ("app/test: add libcrypto")
>=20
> Cc: pablo.de.lara.guarch@intel.com
> Cc: declan.doherty@intel.com
> Cc: andy@warmcat.com
> Cc: stable@dpdk.org
>=20
> Suggested-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>