From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pablo.de.lara.guarch@intel.com>
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
by dpdk.org (Postfix) with ESMTP id 259614C8B
for <dev@dpdk.org>; Tue, 19 Jun 2018 17:25:46 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga007.fm.intel.com ([10.253.24.52])
by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
19 Jun 2018 08:25:44 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.51,243,1526367600"; d="scan'208";a="48267467"
Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23])
by fmsmga007.fm.intel.com with ESMTP; 19 Jun 2018 08:25:41 -0700
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.139]) by
IRSMSX109.ger.corp.intel.com ([169.254.13.225]) with mapi id 14.03.0319.002;
Tue, 19 Jun 2018 16:25:41 +0100
From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: Anoob Joseph <anoob.joseph@caviumnetworks.com>, Akhil Goyal
<akhil.goyal@nxp.com>, Thomas Monjalon <thomas@monjalon.net>
CC: Srisivasubramanian Srinivasan <Srisivasubramanian.Srinivasan@cavium.com>,
Ankur Dwivedi <ankur.dwivedi@cavium.com>, Jerin Jacob
<jerin.jacob@caviumnetworks.com>, Murthy NSSR <Nidadavolu.Murthy@cavium.com>,
Narayana Prasad <narayanaprasad.athreya@caviumnetworks.com>, "Nithin
Dabilpuram" <nithin.dabilpuram@cavium.com>, Ragothaman Jayaraman
<Ragothaman.Jayaraman@cavium.com>, "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [PATCH 10/16] crypto/cpt: add driver initializations
Thread-Index: AQHT/0ixGAC35hmUzkOSC/4HifKVgqRnxJVg
Date: Tue, 19 Jun 2018 15:25:41 +0000
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8977F8D826F@IRSMSX108.ger.corp.intel.com>
References: <1528476325-15585-1-git-send-email-anoob.joseph@caviumnetworks.com>
<1528476325-15585-11-git-send-email-anoob.joseph@caviumnetworks.com>
In-Reply-To: <1528476325-15585-11-git-send-email-anoob.joseph@caviumnetworks.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNWFiN2I0ZTktNzVjYi00NzQ1LThlMzktMDcxMWJjMGRmMTkyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiYW1VVFVnaFU3b0JVb0dLQUtHTjBueXN2OTlKXC9uKzZtZHl2TVpnWU9JQ0g3ZzJSaDlNTEJkOGpOZ1lZRVRhNUgifQ==
x-ctpclassification: CTP_NT
dlp-product: dlpe-windows
dlp-version: 11.0.200.100
dlp-reaction: no-action
x-originating-ip: [163.33.239.181]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH 10/16] crypto/cpt: add driver initializations
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Jun 2018 15:25:47 -0000
> -----Original Message-----
> From: Anoob Joseph [mailto:anoob.joseph@caviumnetworks.com]
> Sent: Friday, June 8, 2018 5:45 PM
> To: Akhil Goyal <akhil.goyal@nxp.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>; Thomas Monjalon <thomas@monjalon.net>
> Cc: Srisivasubramanian Srinivasan
> <Srisivasubramanian.Srinivasan@cavium.com>; Ankur Dwivedi
> <ankur.dwivedi@cavium.com>; Jerin Jacob
> <jerin.jacob@caviumnetworks.com>; Murthy NSSR
> <Nidadavolu.Murthy@cavium.com>; Narayana Prasad
> <narayanaprasad.athreya@caviumnetworks.com>; Nithin Dabilpuram
> <nithin.dabilpuram@cavium.com>; Ragothaman Jayaraman
> <Ragothaman.Jayaraman@cavium.com>; dev@dpdk.org
> Subject: [PATCH 10/16] crypto/cpt: add driver initializations
>=20
> From: Srisivasubramanian Srinivasan
> <Srisivasubramanian.Srinivasan@cavium.com>
>=20
> Introduce driver initialization and enable build infrastructure.
>=20
> Signed-off-by: Ankur Dwivedi <ankur.dwivedi@cavium.com>
> Signed-off-by: Murthy NSSR <Nidadavolu.Murthy@cavium.com>
> Signed-off-by: Nithin Dabilpuram <nithin.dabilpuram@cavium.com>
> Signed-off-by: Ragothaman Jayaraman
> <Ragothaman.Jayaraman@cavium.com>
> Signed-off-by: Srisivasubramanian Srinivasan
> <Srisivasubramanian.Srinivasan@cavium.com>
> ---
> drivers/crypto/cpt/Makefile | 9 +-
> drivers/crypto/cpt/cpt_pmd_cryptodev.c | 270
> +++++++++++++++++++++++++++++++++
> drivers/crypto/cpt/cpt_pmd_logs.h | 50 ++++++
> 3 files changed, 328 insertions(+), 1 deletion(-) create mode 100644
> drivers/crypto/cpt/cpt_pmd_cryptodev.c
> create mode 100644 drivers/crypto/cpt/cpt_pmd_logs.h
>=20
...
> +++ b/drivers/crypto/cpt/cpt_pmd_logs.h
> @@ -0,0 +1,50 @@
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright(c) 2017 Cavium, Inc
> + */
> +
> +#ifndef _CPT_PMD_LOGS_H_
> +#define _CPT_PMD_LOGS_H_
> +
> +#include <rte_log.h>
> +
> +#define PMD_DRV_LOG_RAW(level, fmt, args...) \
> + rte_log(RTE_LOG_ ## level, RTE_LOGTYPE_PMD, \
> + "PMD: %s(): " fmt "\n", __func__, ##args)
> +
> +#ifdef RTE_LIBRTE_PMD_CPT_DEBUG_INIT
> +
> +#define PMD_INIT_FUNC_TRACE() PMD_DRV_LOG_RAW(DEBUG, " >>")
> #define
> +PMD_DRV_LOG(level, args...) \
> + PMD_DRV_LOG_RAW(level, ##args)
> +#else
> +
> +#define PMD_DRV_LOG(...) do { } while (0) #define
> +PMD_INIT_FUNC_TRACE() do { } while (0) #endif
> +
> +#ifdef RTE_LIBRTE_PMD_CPT_DEBUG_RX
> +
> +#define CPT_DEBUG
> +#define CPTVF_STRICT_PARAM_CHECK
> +#define PMD_RX_LOG(level, args...) \
> + PMD_DRV_LOG_RAW(level, ##args)
> +#else
> +
> +#define PMD_RX_LOG(...) do { } while (0) #endif
> +
> +#ifdef RTE_LIBRTE_PMD_CPT_DEBUG_TX
> +
> +#define CPT_DEBUG
> +#define CPTVF_STRICT_PARAM_CHECK
> +
> +#define PMD_TX_LOG(level, args...) \
> + PMD_DRV_LOG_RAW(level, ##args)
> +#else
> +
> +#define PMD_TX_LOG(...) do { } while (0) #endif
> +
> +#define PRINT printf
> +
> +#endif
> --
> 1.9.3
As already said in another commit, use dynamic logging
and try to remove the compilation flags.
Thanks,
Pablo