From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id DD5725B2E for ; Wed, 20 Jun 2018 00:15:16 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Jun 2018 15:15:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,244,1526367600"; d="scan'208";a="58629613" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by FMSMGA003.fm.intel.com with ESMTP; 19 Jun 2018 15:15:14 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.139]) by IRSMSX102.ger.corp.intel.com ([169.254.2.146]) with mapi id 14.03.0319.002; Tue, 19 Jun 2018 23:15:13 +0100 From: "De Lara Guarch, Pablo" To: Shally Verma CC: "Trahe, Fiona" , "dev@dpdk.org" , "pathreya@caviumnetworks.com" , "mchalla@caviumnetworks.com" , Ashish Gupta , Sunila Sahu Thread-Topic: [PATCH v1 1/7] compress/octeontx: add octeontx zip PMD support Thread-Index: AQHT/LkLX3152AI1R06WhFKxL6+M+qRoLQ6A Date: Tue, 19 Jun 2018 22:15:13 +0000 Message-ID: References: <1528194913-25893-1-git-send-email-shally.verma@caviumnetworks.com> <1528194913-25893-2-git-send-email-shally.verma@caviumnetworks.com> In-Reply-To: <1528194913-25893-2-git-send-email-shally.verma@caviumnetworks.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNmE3ZDJkODMtM2ZkOC00MjQ1LWI0ZjgtM2FjMTYwYTk4MzVhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiN09Jdmd3Q01oWTQ2TVJvcDdqa3pmSHRCRmg3bkViWU1UcW0yc0ZkdzdLbWUyRTFVNGg5VGk5d1Q1R2hZNUZFTyJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v1 1/7] compress/octeontx: add octeontx zip PMD support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jun 2018 22:15:17 -0000 > -----Original Message----- > From: Shally Verma [mailto:shally.verma@caviumnetworks.com] > Sent: Tuesday, June 5, 2018 11:35 AM > To: De Lara Guarch, Pablo > Cc: Trahe, Fiona ; dev@dpdk.org; > pathreya@caviumnetworks.com; mchalla@caviumnetworks.com; Ashish Gupta > ; Sunila Sahu > > Subject: [PATCH v1 1/7] compress/octeontx: add octeontx zip PMD support >=20 > Add octeontx zip pmd support in compressdev driver. > Add device probe and remove support. > Update makefile to build octeontx zip pmd Don't forget to update the MAINTAINERS file. Also, there are some compilation errors in the the next patches, when enabling the PMD since the beginning. This should be fixed. >=20 > Signed-off-by: Ashish Gupta > Signed-off-by: Shally Verma > Signed-off-by: Sunila Sahu > --- > config/common_base | 6 + > drivers/compress/Makefile | 2 +- > drivers/compress/octeontx/Makefile | 33 ++++++ > drivers/compress/octeontx/meson.build | 10 ++ > .../octeontx/rte_pmd_octeontx_compress_version.map | 3 + > drivers/compress/octeontx/zip_pmd.c | 129 +++++++++++++++= ++++++ > drivers/compress/octeontx/zipvf.c | 48 ++++++++ > drivers/compress/octeontx/zipvf.h | 47 ++++++++ > usertools/dpdk-devbind.py | 9 ++ > 9 files changed, 286 insertions(+), 1 deletion(-) >=20 > diff --git a/config/common_base b/config/common_base index > 6b0d1cbbb..e56d14b7f 100644 > --- a/config/common_base > +++ b/config/common_base > @@ -584,6 +584,12 @@ CONFIG_RTE_COMPRESS_MAX_DEVS=3D64 # > CONFIG_RTE_COMPRESSDEV_TEST=3Dn >=20 > +# > +# Compile PMD for Octeontx ZIPVF compression device # > +CONFIG_RTE_LIBRTE_PMD_OCTEONTX_ZIPVF=3Dn > +CONFIG_RTE_LIBRTE_PMD_OCTEONTX_ZIPVF_DEBUG=3Dn As Jerin said, the PMD can be enabled by default, right? As far as I know, this PMD has no external dependencies. Also, the DEBUG flag can be removed. > + > # > # Compile PMD for ISA-L compression device # diff --git > a/drivers/compress/Makefile b/drivers/compress/Makefile index > 592497f51..62b4e5abe 100644 > --- a/drivers/compress/Makefile > +++ b/drivers/compress/Makefile > @@ -4,5 +4,5 @@ > include $(RTE_SDK)/mk/rte.vars.mk >=20 > DIRS-$(CONFIG_RTE_LIBRTE_PMD_ISAL) +=3D isal > - > +DIRS-$(CONFIG_RTE_LIBRTE_PMD_OCTEONTX_ZIPVF) +=3D octeontx Add this without removing the blank line. > include $(RTE_SDK)/mk/rte.subdir.mk > diff --git a/drivers/compress/octeontx/Makefile > b/drivers/compress/octeontx/Makefile > new file mode 100644 > index 000000000..89078f085 > --- /dev/null > +++ b/drivers/compress/octeontx/Makefile > @@ -0,0 +1,33 @@ > +# SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2017-2018 Cavium > +Networks > + > +include $(RTE_SDK)/mk/rte.vars.mk > + > +# library name > +LIB =3D librte_pmd_octeontx_zip.a > + > +# library version > +LIBABIVER :=3D 1 > + > +# build flags > +CFLAGS +=3D $(WERROR_FLAGS) > +CFLAGS +=3D -O3 > +CFLAGS +=3D -DALLOW_EXPERIMENTAL_API > +CFLAGS +=3D -I$(RTE_SDK)/drivers/compress/octeontx/include Is this include necessary? Also, there is not /include in this patch. > + > +# external library include paths > +LDLIBS +=3D -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring LDLIBS +=3D > +-lrte_compressdev LDLIBS +=3D -lrte_pci -lrte_bus_pci > + > +# library source files > +SRCS-$(CONFIG_RTE_LIBRTE_PMD_OCTEONTX_ZIPVF) +=3D zip_pmd.c > +SRCS-$(CONFIG_RTE_LIBRTE_PMD_OCTEONTX_ZIPVF) +=3D zipvf.c > + > +# export include files > +SYMLINK-y-include +=3D > + > +# versioning export map > +EXPORT_MAP :=3D rte_pmd_octeontx_compress_version.map > + > +include $(RTE_SDK)/mk/rte.lib.mk > diff --git a/drivers/compress/octeontx/meson.build > b/drivers/compress/octeontx/meson.build > new file mode 100644 > index 000000000..cce404337 > --- /dev/null > +++ b/drivers/compress/octeontx/meson.build > @@ -0,0 +1,10 @@ > +# SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2018 Cavium > +Networks > + > +sources =3D files('zipvf.c', 'zip_pmd.c') allow_experimental_apis =3D tr= ue > +includes +=3D include_directories('include') deps +=3D ['mempool_octeont= x', > +'bus_pci'] ext_deps +=3D dep > + > + > diff --git > a/drivers/compress/octeontx/rte_pmd_octeontx_compress_version.map > b/drivers/compress/octeontx/rte_pmd_octeontx_compress_version.map > new file mode 100644 > index 000000000..33c1b976f > --- /dev/null > +++ b/drivers/compress/octeontx/rte_pmd_octeontx_compress_version.map > @@ -0,0 +1,3 @@ > +EXPERIMENTAL { > + local: *; > +}; I think this can be 18.08, as there is no API, so we won't need to modify this once the compression API turns stable. > diff --git a/drivers/compress/octeontx/zip_pmd.c > b/drivers/compress/octeontx/zip_pmd.c > new file mode 100644 > index 000000000..1181bed19 > --- /dev/null > +++ b/drivers/compress/octeontx/zip_pmd.c ... > +++ b/drivers/compress/octeontx/zipvf.c > @@ -0,0 +1,48 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright(c) 2017-2018 Cavium Networks */ > + > +#include "zipvf.h" > + > +int zipvf_create(struct rte_compressdev *compressdev, int vfid) { Return type should be in the line before the function name.