From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pablo.de.lara.guarch@intel.com>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
by dpdk.org (Postfix) with ESMTP id AB3945F32
for <dev@dpdk.org>; Wed, 20 Jun 2018 00:18:23 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga007.fm.intel.com ([10.253.24.52])
by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
19 Jun 2018 15:18:22 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.51,244,1526367600"; d="scan'208";a="48364994"
Received: from irsmsx154.ger.corp.intel.com ([163.33.192.96])
by fmsmga007.fm.intel.com with ESMTP; 19 Jun 2018 15:18:20 -0700
Received: from irsmsx155.ger.corp.intel.com (163.33.192.3) by
IRSMSX154.ger.corp.intel.com (163.33.192.96) with Microsoft SMTP Server (TLS)
id 14.3.319.2; Tue, 19 Jun 2018 23:18:19 +0100
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.139]) by
irsmsx155.ger.corp.intel.com ([169.254.14.241]) with mapi id 14.03.0319.002;
Tue, 19 Jun 2018 23:18:19 +0100
From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: Shally Verma <shally.verma@caviumnetworks.com>
CC: "Trahe, Fiona" <fiona.trahe@intel.com>, "dev@dpdk.org" <dev@dpdk.org>,
"pathreya@caviumnetworks.com" <pathreya@caviumnetworks.com>,
"mchalla@caviumnetworks.com" <mchalla@caviumnetworks.com>, Ashish Gupta
<ashish.gupta@caviumnetworks.com>, Sunila Sahu
<sunila.sahu@caviumnetworks.com>
Thread-Topic: [PATCH v1 4/7] compress/octeontx: add ops enq deq apis
Thread-Index: AQHT/LkhkqIYUcANvECY0SLOV1J/HqRoPOCg
Date: Tue, 19 Jun 2018 22:18:19 +0000
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8977F8D856E@IRSMSX108.ger.corp.intel.com>
References: <1528194913-25893-1-git-send-email-shally.verma@caviumnetworks.com>
<1528194913-25893-5-git-send-email-shally.verma@caviumnetworks.com>
In-Reply-To: <1528194913-25893-5-git-send-email-shally.verma@caviumnetworks.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTFjMDdiOTItNTI5OS00ZTcxLTgzMjMtNTJmYzE5Y2M5ZjU3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiKzdpTGdCQVJ0dVk2SEN3ZkJZV2Y3MEdTRXpjN1FzWUVDbHM0ZkFjcThDa3JIRHJlMXp5QndwNzlPZVkydlwvamsifQ==
x-ctpclassification: CTP_NT
dlp-product: dlpe-windows
dlp-version: 11.0.200.100
dlp-reaction: no-action
x-originating-ip: [163.33.239.181]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v1 4/7] compress/octeontx: add ops enq deq
apis
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Jun 2018 22:18:24 -0000
> -----Original Message-----
> From: Shally Verma [mailto:shally.verma@caviumnetworks.com]
> Sent: Tuesday, June 5, 2018 11:35 AM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Cc: Trahe, Fiona <fiona.trahe@intel.com>; dev@dpdk.org;
> pathreya@caviumnetworks.com; mchalla@caviumnetworks.com; Ashish Gupta
> <ashish.gupta@caviumnetworks.com>; Sunila Sahu
> <sunila.sahu@caviumnetworks.com>
> Subject: [PATCH v1 4/7] compress/octeontx: add ops enq deq apis
>=20
> implement enqueue and dequeue apis
>=20
> Signed-off-by: Ashish Gupta <ashish.gupta@caviumnetworks.com>
> Signed-off-by: Shally Verma <shally.verma@caviumnetworks.com>
> Signed-off-by: Sunila Sahu <sunila.sahu@caviumnetworks.com>
...
> --- a/drivers/compress/octeontx/zipvf.h
> +++ b/drivers/compress/octeontx/zipvf.h
...
> +static inline int
> +zipvf_prepare_out_buf(struct zip_stream *zstrm, struct rte_comp_op *op)
> +{
> + uint32_t offset;
> + union zip_zptr_s *sg_list =3D NULL;
> + struct rte_mbuf *m_dst;
> + union zip_inst_s *inst =3D zstrm->inst;
> + rte_iova_t iova;
> +
> + offset =3D op->src.offset;
> + m_dst =3D op->m_dst;
> +
> + if (m_dst->nb_segs =3D=3D 1) {
> + /* Prepare direct input data pointer */
> + inst->s.ds =3D 0;
> + inst->s.out_ptr_addr.s.addr =3D
> + rte_pktmbuf_iova_offset(m_dst, offset);
> + inst->s.totaloutputlength =3D rte_pktmbuf_data_len(m_dst) -
> + op->dst.offset;
> + inst->s.out_ptr_ctl.s.length =3D inst->s.totaloutputlength;
> + return 0;
> + }
> +
> + ZIP_PMD_ERR("output packet is segmented\n");
> +
> + /* Packet is segmented, create gather buffer */
> + inst->s.ds =3D 1;
> + iova =3D rte_mempool_virt2iova(zstrm->bufs[OUT_DATA_BUF]);
> + if (iova & 0xF) {
> + /* Align it to 16 Byte address */
> + iova =3D ZIP_ALIGN_ROUNDUP(iova, ZIP_SGPTR_ALIGN);
> + }
> +
> + inst->s.out_ptr_addr.s.addr =3D iova;
> + inst->s.inp_ptr_ctl.s.length =3D (m_dst->nb_segs < MAX_SG_LEN) ?
> + (m_dst->nb_segs) : MAX_SG_LEN;
> +
> + sg_list =3D (union zip_zptr_s *)iova;
There is a compilation issue on gcc 32 bits:
drivers/compress/octeontx/zipvf.h:260:12: error:
cast to pointer from integer of different size [-Werror=3Dint-to-pointer-ca=
st]
sg_list =3D (union zip_zptr_s *)iova;