From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 63C111BF83 for ; Wed, 27 Jun 2018 18:19:08 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Jun 2018 09:19:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,279,1526367600"; d="scan'208";a="60601171" Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by FMSMGA003.fm.intel.com with ESMTP; 27 Jun 2018 09:19:06 -0700 Received: from irsmsx111.ger.corp.intel.com (10.108.20.4) by IRSMSX106.ger.corp.intel.com (163.33.3.31) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 27 Jun 2018 17:19:05 +0100 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.139]) by irsmsx111.ger.corp.intel.com ([169.254.2.230]) with mapi id 14.03.0319.002; Wed, 27 Jun 2018 17:19:05 +0100 From: "De Lara Guarch, Pablo" To: "Babu Radhakrishnan, AgalyaX" , "dev@dpdk.org" CC: "Pattan, Reshma" Thread-Topic: [PATCH] crypto/zuc: add dynamic logging to zuc Thread-Index: AQHUCgtkAqDtsQowd0uPtZG8Qk7rX6R0T1Ng Date: Wed, 27 Jun 2018 16:19:04 +0000 Message-ID: References: <1529659681-28346-1-git-send-email-agalyax.babu.radhakrishnan@intel.com> In-Reply-To: <1529659681-28346-1-git-send-email-agalyax.babu.radhakrishnan@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNGJlYTliYmMtM2RhZi00Nzg4LTg5YmEtNGJiODJmNGY0YzBhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUHlqZXZoeDkxc3dUbjN2alMrRUtyMWtveml6ZHdYekVseWhVTmZTaUp2b3R1MXYyTjFuS1hzcUZJOVZua1JzNSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] crypto/zuc: add dynamic logging to zuc X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jun 2018 16:19:09 -0000 Hi Agalya, > -----Original Message----- > From: Babu Radhakrishnan, AgalyaX > Sent: Friday, June 22, 2018 10:28 AM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Pattan, Reshm= a > ; Babu Radhakrishnan, AgalyaX > > Subject: [PATCH] crypto/zuc: add dynamic logging to zuc >=20 > 1.added new logtype for zuc driver. > 2.registered new logtype. > 3.ZUC_LOG_ERR and CDEV_LOG_ERR are > replaced with new logtype name ZUC_PMD_LOG >=20 > Signed-off-by: Agalya Babu RadhaKrishnan > > Reviewed-by: Reshma Pattan Could you make the following changes? - Change the macro to ZUC_LOG, to make it shorter. - Change title to: crypto/zuc: add dynamic logging - Is your surname RadhaKrishnan all together or with a space? Because there is a mismatch between the author and the Signed-off-by line. - Remove unused "CONFIG_RTE_LIBRTE_PMD_ZUC_DEBUG=3Dn" from config file. - Set log level of the new type to INFO (see isal_compress_pmd.c) Thanks, Pablo