From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pablo.de.lara.guarch@intel.com>
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
by dpdk.org (Postfix) with ESMTP id 794C03772
for <dev@dpdk.org>; Mon, 9 Jul 2018 16:17:01 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga003.jf.intel.com ([10.7.209.27])
by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
09 Jul 2018 07:17:00 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.51,330,1526367600"; d="scan'208";a="65493162"
Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25])
by orsmga003.jf.intel.com with ESMTP; 09 Jul 2018 07:16:54 -0700
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.139]) by
irsmsx110.ger.corp.intel.com ([169.254.15.152]) with mapi id 14.03.0319.002;
Mon, 9 Jul 2018 15:16:53 +0100
From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: "Wang, Yipeng1" <yipeng1.wang@intel.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, "Richardson, Bruce"
<bruce.richardson@intel.com>, "honnappa.nagarahalli@arm.com"
<honnappa.nagarahalli@arm.com>, "vguvva@caviumnetworks.com"
<vguvva@caviumnetworks.com>, "brijesh.s.singh@gmail.com"
<brijesh.s.singh@gmail.com>
Thread-Topic: [PATCH v3 2/8] hash: fix a multi-writer bug
Thread-Index: AQHUFZ3C4iiYUk09vEOQ5zg5cJfTuaSG8wzw
Date: Mon, 9 Jul 2018 14:16:53 +0000
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8977F8E82A0@IRSMSX108.ger.corp.intel.com>
References: <1528455078-328182-1-git-send-email-yipeng1.wang@intel.com>
<1530906406-289697-1-git-send-email-yipeng1.wang@intel.com>
<1530906406-289697-3-git-send-email-yipeng1.wang@intel.com>
In-Reply-To: <1530906406-289697-3-git-send-email-yipeng1.wang@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMWY1MzZlZDEtMWI4Mi00ZTlhLWEyNGUtYjZjOGZjNzYwOThhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiOVRYbHdnZ3pwV2RTbWNKYmVhR1U1WENuemNva0IxczBNeTdYaXQ1Rm14cDc1elBFWTQ1U0UwRWE2S2w4XC9QQkQifQ==
x-ctpclassification: CTP_NT
dlp-product: dlpe-windows
dlp-version: 11.0.200.100
dlp-reaction: no-action
x-originating-ip: [163.33.239.182]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v3 2/8] hash: fix a multi-writer bug
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 09 Jul 2018 14:17:01 -0000
> -----Original Message-----
> From: Wang, Yipeng1
> Sent: Friday, July 6, 2018 8:47 PM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Cc: dev@dpdk.org; Wang, Yipeng1 <yipeng1.wang@intel.com>; Richardson,
> Bruce <bruce.richardson@intel.com>; honnappa.nagarahalli@arm.com;
> vguvva@caviumnetworks.com; brijesh.s.singh@gmail.com
> Subject: [PATCH v3 2/8] hash: fix a multi-writer bug
Just a minor comment on the title. It should be a summary of the commit
(try to summarize the bug, instead of using the word "bug").
Keep my ack for the next version (like in other patches).
>=20
> Current multi-writer implementation uses Intel TSX to protect the cuckoo =
path
> moving but not the cuckoo path searching. After searching, we need to ver=
ify
> again if the same empty slot still exists at the beginning of the TSX reg=
ion.
> Otherwise another writer could occupy the empty slot before the TSX regio=
n.
> Current code does not verify.
>=20
> Fixes: be856325cba3 ("hash: add scalable multi-writer insertion with Inte=
l TSX")
> Cc: stable@dpdk.org
>=20
> Signed-off-by: Yipeng Wang <yipeng1.wang@intel.com>
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>