From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 9BD015A44 for ; Thu, 12 Jul 2018 14:41:57 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Jul 2018 05:41:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,342,1526367600"; d="scan'208";a="71767949" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by fmsmga001.fm.intel.com with ESMTP; 12 Jul 2018 05:41:51 -0700 Received: from irsmsx156.ger.corp.intel.com (10.108.20.68) by IRSMSX102.ger.corp.intel.com (163.33.3.155) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 12 Jul 2018 13:41:50 +0100 Received: from irsmsx107.ger.corp.intel.com ([169.254.10.193]) by IRSMSX156.ger.corp.intel.com ([169.254.3.205]) with mapi id 14.03.0319.002; Thu, 12 Jul 2018 13:41:50 +0100 From: "De Lara Guarch, Pablo" To: "Trahe, Fiona" , "dev@dpdk.org" CC: "Jozwiak, TomaszX" Thread-Topic: [PATCH v5 02/16] compress/qat: add makefiles for PMD Thread-Index: AQHUGQ5lhpIBATwf9UmwO776UvXePqSLfHaw Date: Thu, 12 Jul 2018 12:41:49 +0000 Message-ID: References: <1531183311-32619-1-git-send-email-fiona.trahe@intel.com> <1531310229-17448-3-git-send-email-fiona.trahe@intel.com> In-Reply-To: <1531310229-17448-3-git-send-email-fiona.trahe@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDFlYmY0ZjMtMmQzMC00MWY4LTlhNWItNzE3NjMyNjhiOGJiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiTW1jUm5zUWpqbWtUY3Buamc0djNUWGZcLzhzdE9qMnp5QmNORWpveTJ6WERJQkdZUFprVFMxZVFoM1g3MlB4M3AifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5 02/16] compress/qat: add makefiles for PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Jul 2018 12:41:58 -0000 > -----Original Message----- > From: Trahe, Fiona > Sent: Wednesday, July 11, 2018 12:57 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Trahe, Fiona > ; Jozwiak, TomaszX > Subject: [PATCH v5 02/16] compress/qat: add makefiles for PMD >=20 > Add Makefiles, directory and empty source files for compression PMD. > Handle cases for building either symmetric crypto PMD or compression PMD = or > both and the common files both depend on. >=20 > Signed-off-by: Fiona Trahe > Signed-off-by: Tomasz Jozwiak > --- > MAINTAINERS | 4 +++ > config/common_base | 3 +- > drivers/common/qat/Makefile | 60 +++++++++++++++++++++++--------= ------ > drivers/compress/qat/qat_comp.c | 5 ++++ > drivers/compress/qat/qat_comp.h | 14 +++++++++ > drivers/compress/qat/qat_comp_pmd.c | 5 ++++ > drivers/compress/qat/qat_comp_pmd.h | 15 ++++++++++ > test/test/test_cryptodev.c | 6 ++-- > 8 files changed, 86 insertions(+), 26 deletions(-) create mode 100644 > drivers/compress/qat/qat_comp.c create mode 100644 > drivers/compress/qat/qat_comp.h create mode 100644 > drivers/compress/qat/qat_comp_pmd.c > create mode 100644 drivers/compress/qat/qat_comp_pmd.h >=20 > diff --git a/MAINTAINERS b/MAINTAINERS > index 8050b5d..50b2dff 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -852,6 +852,10 @@ F: drivers/compress/isal/ > F: doc/guides/compressdevs/isal.rst > F: doc/guides/compressdevs/features/isal.ini >=20 > +Intel QuickAssist > +M: Fiona Trahe > +F: drivers/compress/qat/ > +F: drivers/common/qat/ >=20 > Eventdev Drivers > ---------------- > diff --git a/config/common_base b/config/common_base index > e4241db..1e340b4 100644 > --- a/config/common_base > +++ b/config/common_base > @@ -480,7 +480,8 @@ CONFIG_RTE_LIBRTE_DPAA_MAX_CRYPTODEV=3D4 > # > # Compile PMD for QuickAssist based devices # - > CONFIG_RTE_LIBRTE_PMD_QAT=3Dn > +CONFIG_RTE_LIBRTE_PMD_QAT=3Dy > +CONFIG_RTE_LIBRTE_PMD_QAT_SYM=3Dn Since now you are enabling QAT driver by default, mk/rte.app.mk needs to be= changed. QAT_SYM requires libcrypto, not QAT itself, so right now, by default libcry= pto is needed. A change like the following would solve the problem, but not sure if it is = correct. +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_QAT) +=3D -lrte_pmd_qat ifeq ($(CONFIG_RTE_LIBRTE_CRYPTODEV),y) _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_AESNI_MB) +=3D -lrte_pmd_aesni_mb _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_AESNI_MB) +=3D -lIPSec_MB @@ -190,7 +191,7 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_AESNI_GCM) +=3D -lIPS= ec_MB _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_CCP) +=3D -lrte_pmd_ccp -lcrypto _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_OPENSSL) +=3D -lrte_pmd_openssl -lcryp= to _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_NULL_CRYPTO) +=3D -lrte_pmd_null_crypto -_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_QAT) +=3D -lrte_pmd_qat -lcrypto +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_QAT_SYM) +=3D -lcrypto