From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: "Daly, Lee" <lee.daly@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/3] compress/isal: fix logtype name
Date: Fri, 13 Jul 2018 14:40:23 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8977F8FA3E4@IRSMSX107.ger.corp.intel.com> (raw)
In-Reply-To: <F5C6929789601049BEB7272E2673559858C771@irsmsx105.ger.corp.intel.com>
> -----Original Message-----
> From: Daly, Lee
> Sent: Wednesday, July 11, 2018 5:15 PM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: RE: [PATCH 1/3] compress/isal: fix logtype name
>
>
>
> > -----Original Message-----
> > From: De Lara Guarch, Pablo
> > Sent: Wednesday, July 11, 2018 7:39 AM
> > To: Daly, Lee <lee.daly@intel.com>
> > Cc: dev@dpdk.org; De Lara Guarch, Pablo
> > <pablo.de.lara.guarch@intel.com>; stable@dpdk.org
> > Subject: [PATCH 1/3] compress/isal: fix logtype name
> >
> > There is a naming convention for logtypes of PMDs:
> > "pmd.driverType.driverName".
> > Therefore, the logtype for ISA-L PMD should be "pmd.compress.isal".
> >
> > Fixes: 490e725b95b2 ("compress/isal: add device init and de-init")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> > ---
> > drivers/compress/isal/isal_compress_pmd.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/compress/isal/isal_compress_pmd.c
> > b/drivers/compress/isal/isal_compress_pmd.c
> > index 0f025a3bf..a3b28f29b 100644
> > --- a/drivers/compress/isal/isal_compress_pmd.c
> > +++ b/drivers/compress/isal/isal_compress_pmd.c
> > @@ -465,7 +465,7 @@ RTE_INIT(isal_init_log); static void
> > isal_init_log(void)
> > {
> > - isal_logtype_driver = rte_log_register("comp_isal");
> > + isal_logtype_driver = rte_log_register("pmd.compress.isal");
> > if (isal_logtype_driver >= 0)
> > rte_log_set_level(isal_logtype_driver, RTE_LOG_INFO); }
> > --
> > 2.14.4
> Acked-by: Lee Daly <lee.daly@intel.com>
Series applied to dpdk-next-crypto.
Thanks,
Pablo
prev parent reply other threads:[~2018-07-13 14:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-11 6:38 Pablo de Lara
2018-07-11 6:38 ` [dpdk-dev] [PATCH 2/3] compress/isal: set null pointer after freeing Pablo de Lara
2018-07-11 16:14 ` Daly, Lee
2018-07-11 6:38 ` [dpdk-dev] [PATCH 3/3] compress/isal: fix memory leak Pablo de Lara
2018-07-11 16:13 ` Daly, Lee
2018-07-11 16:14 ` [dpdk-dev] [PATCH 1/3] compress/isal: fix logtype name Daly, Lee
2018-07-13 14:40 ` De Lara Guarch, Pablo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8977F8FA3E4@IRSMSX107.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=dev@dpdk.org \
--cc=lee.daly@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).