DPDK patches and discussions
 help / color / mirror / Atom feed
From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] devtools: add compressdev tests to test-build
Date: Mon, 16 Jul 2018 17:33:27 +0000	[thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8977F8FBE1B@IRSMSX107.ger.corp.intel.com> (raw)
In-Reply-To: <1571428.5RkRqaR3OR@xps>

HI Thomas,

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Wednesday, July 11, 2018 4:50 PM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [PATCH] devtools: add compressdev tests to test-build
> 
> 11/07/2018 09:17, Pablo de Lara:
> > Compressdev tests depend on Zlib library, so they can only be enabled
> > if this is available.
> >
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> > ---
> > --- a/devtools/test-build.sh
> > +++ b/devtools/test-build.sh
> > @@ -154,6 +154,7 @@ config () # <directory> <target> <options>
> >  		test "$DPDK_DEP_ZLIB" != y || \
> >  		sed -ri          's,(BNX2X_PMD=)n,\1y,' $1/.config
> >  		sed -ri            's,(NFP_PMD=)n,\1y,' $1/.config
> > +		sed -ri   's,(COMPRESSDEV_TEST=)n,\1y,' $1/.config
> 
> It is always enabled here.
> You need to repeat the ZLIB condition for NFP and COMPRESSDEV_TEST.
> 

I see. So, does this mean that NFP PMD is always enabled? Do we need a fix for that?

Thanks,
Pablo

> 
> 

  reply	other threads:[~2018-07-16 17:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-11  7:17 Pablo de Lara
2018-07-11 15:49 ` Thomas Monjalon
2018-07-16 17:33   ` De Lara Guarch, Pablo [this message]
2018-07-16 19:50     ` Thomas Monjalon
2018-07-19  3:07 ` [dpdk-dev] [PATCH v2] " Pablo de Lara
2018-07-26  9:04   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8977F8FBE1B@IRSMSX107.ger.corp.intel.com \
    --to=pablo.de.lara.guarch@intel.com \
    --cc=dev@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).