From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 5184AF72 for ; Mon, 23 Jul 2018 15:00:11 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Jul 2018 06:00:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,393,1526367600"; d="scan'208";a="73721103" Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by fmsmga004.fm.intel.com with ESMTP; 23 Jul 2018 06:00:09 -0700 Received: from irsmsx107.ger.corp.intel.com ([169.254.10.193]) by IRSMSX151.ger.corp.intel.com ([169.254.4.36]) with mapi id 14.03.0319.002; Mon, 23 Jul 2018 14:00:09 +0100 From: "De Lara Guarch, Pablo" To: "Verma, Shally" CC: "dev@dpdk.org" , "Athreya, Narayana Prasad" , "Challa, Mahipal" , "Gupta, Ashish" , "Sahu, Sunila" , "Sahu, Sunila" Thread-Topic: [PATCH v3 4/5] compress/zlib: support burst enqueue/dequeue Thread-Index: AQHUIR89STGvFUefL0GSoNPZICA3xaScwOMQ///0KgCAABKloA== Date: Mon, 23 Jul 2018 13:00:08 +0000 Message-ID: References: <1532197069-24224-1-git-send-email-shally.verma@caviumnetworks.com> <1532197069-24224-5-git-send-email-shally.verma@caviumnetworks.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzc4MjI3NDctMDc0Zi00YzY5LTkwOTMtMWNlNmRjY2RlZGE4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiSStENVFDTVpzcXZ2Y0hwdDcxdExmVTRKWXpPTVJoZzlrUHNqXC9oSGJKeHlnYXdNR3BLcDNFVTJ4d0lLV2s5bTAifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 4/5] compress/zlib: support burst enqueue/dequeue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Jul 2018 13:00:12 -0000 > -----Original Message----- > From: Verma, Shally [mailto:Shally.Verma@cavium.com] > Sent: Monday, July 23, 2018 1:53 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; Athreya, Narayana Prasad > ; Challa, Mahipal > ; Gupta, Ashish ; > Sahu, Sunila ; Sahu, Sunila > > Subject: RE: [PATCH v3 4/5] compress/zlib: support burst enqueue/dequeue >=20 > Hi Pablo >=20 > >-----Original Message----- > >From: De Lara Guarch, Pablo > >Sent: 23 July 2018 18:07 > >To: Verma, Shally > >Cc: dev@dpdk.org; Athreya, Narayana Prasad > >; Challa, Mahipal > >; Gupta, Ashish ; > >Sahu, Sunila ; Sahu, Sunila > > > >Subject: RE: [PATCH v3 4/5] compress/zlib: support burst > >enqueue/dequeue > > > >External Email > > > >> -----Original Message----- > >> From: Shally Verma [mailto:shally.verma@caviumnetworks.com] > >> Sent: Saturday, July 21, 2018 7:18 PM > >> To: De Lara Guarch, Pablo > >> Cc: dev@dpdk.org; pathreya@caviumnetworks.com; > >> mchalla@caviumnetworks.com; ashish.gupta@caviumnetworks.com; > >> sunila.sahu@caviumnetworks.com; Sunila Sahu > >> > >> Subject: [PATCH v3 4/5] compress/zlib: support burst enqueue/dequeue > >> > >> From: Sunila Sahu > >> > >> Signed-off-by: Sunila Sahu > >> Signed-off-by: Shally Verma > >> Signed-off-by: Ashish Gupta > >> --- > >> drivers/compress/zlib/zlib_pmd.c | 254 > > > >... > > > >> +def_end: > >> + /* Update op stats */ > >> + switch (op->status) { > >> + case RTE_COMP_OP_STATUS_SUCCESS: > >> + op->consumed +=3D strm->total_in; > > > >Compilation issue here: > > > >drivers/compress/zlib/zlib_pmd.c:94:16: error: this statement may fall t= hrough > [-Werror=3Dimplicit-fallthrough=3D] > > op->consumed +=3D strm->total_in; > > ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~ > > > >I think you are missing a "/* Fall-through */" comment here. > OK. I will send next patch immediately with this fix. But which compiler = version > you following, since this isn't seen during our build (which we did on mu= ltiple > platforms) so want to understand what is the environment we need to have = to > avoid such regressions. I see this with gcc 7.2.1 (on Fedora 27). Pablo >=20 > Thanks > Shally >=20 > > > >Thanks, > >Pablo > > > >> + case RTE_COMP_OP_STATUS_OUT_OF_SPACE_TERMINATED: > >> + op->produced +=3D strm->total_out; > >> + break;