Re: [dpdk-dev] [PATCH v4 1/5] compress/zlib: add ZLIB PMD

["De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>]

> -----Original Message-----
> From: Shally Verma [mailto:shally.verma@caviumnetworks.com]
> Sent: Monday, July 23, 2018 3:51 PM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Cc: dev@dpdk.org; pathreya@caviumnetworks.com;
> mchalla@caviumnetworks.com; Ashish Gupta
> <ashish.gupta@caviumnetworks.com>; Sunila Sahu
> <sunila.sahu@caviumnetworks.com>
> Subject: [PATCH v4 1/5] compress/zlib: add ZLIB PMD
> 
> From: Ashish Gupta <ashish.gupta@caviumnetworks.com>
> 
> Add initial PMD setup routines in compressdev framework. ZLIB PMD appears as
> virtual compression device. User would need to install zlib prior to enabling this
> PMD.
> 
> Signed-off-by: Sunila Sahu <sunila.sahu@caviumnetworks.com>
> Signed-off-by: Shally Verma <shally.verma@caviumnetworks.com>
> Signed-off-by: Ashish Gupta <ashish.gupta@caviumnetworks.com>

...

> +++ b/drivers/compress/zlib/zlib_pmd.c

...

> +static int
> +zlib_probe(struct rte_vdev_device *vdev) {
> +	struct rte_compressdev_pmd_init_params init_params = {
> +		"",
> +		rte_socket_id()
> +	};
> +	const char *name;
> +	const char *input_args;
> +
> +	name = rte_vdev_device_name(vdev);
> +
> +	if (name == NULL)
> +		return -EINVAL;
> +	input_args = rte_vdev_device_args(vdev);
> +	rte_compressdev_pmd_parse_input_args(&init_params, input_args);

Need to check the return value of this function.