From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 60270235 for ; Tue, 24 Jul 2018 00:02:50 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Jul 2018 15:02:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,394,1526367600"; d="scan'208";a="218442233" Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25]) by orsmga004.jf.intel.com with ESMTP; 23 Jul 2018 15:02:47 -0700 Received: from irsmsx107.ger.corp.intel.com ([169.254.10.193]) by irsmsx110.ger.corp.intel.com ([169.254.15.197]) with mapi id 14.03.0319.002; Mon, 23 Jul 2018 23:02:46 +0100 From: "De Lara Guarch, Pablo" To: Shally Verma CC: "dev@dpdk.org" , "pathreya@caviumnetworks.com" , "mchalla@caviumnetworks.com" , Ashish Gupta , Sunila Sahu Thread-Topic: [PATCH v4 2/5] compress/zlib: add device PMD ops Thread-Index: AQHUIpS7t97xwW36jE+ykCjp2a4ocKSdW3zw Date: Mon, 23 Jul 2018 22:02:46 +0000 Message-ID: References: <1532357474-9544-1-git-send-email-shally.verma@caviumnetworks.com> <1532357474-9544-3-git-send-email-shally.verma@caviumnetworks.com> In-Reply-To: <1532357474-9544-3-git-send-email-shally.verma@caviumnetworks.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDI5NWQ0Y2EtZTNjNy00MThmLTk4YWMtZjhiYTFiZTEyYjYyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiU3lCUmNoU1ZNWmxtUmhmc1wvTlhIdG5vZzhxM1NsdmJ0d2NrOXpzZXFRVGd6WSs4dkFHZk1XTXRyTzl5VksyZVIifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 2/5] compress/zlib: add device PMD ops X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Jul 2018 22:02:50 -0000 > -----Original Message----- > From: Shally Verma [mailto:shally.verma@caviumnetworks.com] > Sent: Monday, July 23, 2018 3:51 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; pathreya@caviumnetworks.com; > mchalla@caviumnetworks.com; Ashish Gupta > ; Sunila Sahu > > Subject: [PATCH v4 2/5] compress/zlib: add device PMD ops >=20 > From: Ashish Gupta >=20 > Implement device configure and queue pair setup PMD ops >=20 > Signed-off-by: Sunila Sahu > Signed-off-by: Shally Verma > Signed-off-by: Ashish Gupta ... > --- /dev/null > +++ b/drivers/compress/zlib/zlib_pmd_ops.c > @@ -0,0 +1,238 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright(c) 2018 Cavium Networks > + */ > + > +#include > + > +#include > +#include > + > +#include "zlib_pmd_private.h" > + > +static const struct rte_compressdev_capabilities zlib_pmd_capabilities[]= =3D { > + { /* Deflate */ > + .algo =3D RTE_COMP_ALGO_DEFLATE, > + .comp_feature_flags =3D > (RTE_COMP_FF_NONCOMPRESSED_BLOCKS | > + RTE_COMP_FF_HUFFMAN_FIXED | > + RTE_COMP_FF_HUFFMAN_DYNAMIC | > + > RTE_COMP_FF_OOP_SGL_IN_SGL_OUT), As said in the document patch, I think you should add the other two SGL cas= es here.