Re: [dpdk-dev] [PATCH v4 5/5] doc: add ZLIB PMD guide

["De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>]

> -----Original Message-----
> From: Verma, Shally [mailto:Shally.Verma@cavium.com]
> Sent: Tuesday, July 24, 2018 6:32 AM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Cc: dev@dpdk.org; Athreya, Narayana Prasad
> <NarayanaPrasad.Athreya@cavium.com>; Challa, Mahipal
> <Mahipal.Challa@cavium.com>; Sahu, Sunila <Sunila.Sahu@cavium.com>;
> Gupta, Ashish <Ashish.Gupta@cavium.com>
> Subject: RE: [dpdk-dev] [PATCH v4 5/5] doc: add ZLIB PMD guide
> 
> 
> 
> >-----Original Message-----
> >From: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> >Sent: 24 July 2018 02:49
> >To: Verma, Shally <Shally.Verma@cavium.com>
> >Cc: dev@dpdk.org; Athreya, Narayana Prasad
> ><NarayanaPrasad.Athreya@cavium.com>; Challa, Mahipal
> ><Mahipal.Challa@cavium.com>; Sahu, Sunila <Sunila.Sahu@cavium.com>;
> >Gupta, Ashish <Ashish.Gupta@cavium.com>
> >Subject: RE: [dpdk-dev] [PATCH v4 5/5] doc: add ZLIB PMD guide
> >
> >External Email
> >
> >Hi Shally,
> >
> >> -----Original Message-----
> >> From: Verma, Shally [mailto:Shally.Verma@cavium.com]
> >> Sent: Monday, July 23, 2018 7:00 PM
> >> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> >> Cc: dev@dpdk.org; Athreya, Narayana Prasad
> >> <NarayanaPrasad.Athreya@cavium.com>; Challa, Mahipal
> >> <Mahipal.Challa@cavium.com>; Sahu, Sunila <Sunila.Sahu@cavium.com>;
> >> Gupta, Ashish <Ashish.Gupta@cavium.com>
> >> Subject: RE: [dpdk-dev] [PATCH v4 5/5] doc: add ZLIB PMD guide
> >>
> >>
> >>
> >> >-----Original Message-----
> >> >From: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> >> >Sent: 23 July 2018 23:28
> >> >To: Verma, Shally <Shally.Verma@cavium.com>
> >> >Cc: dev@dpdk.org; Athreya, Narayana Prasad
> >> ><NarayanaPrasad.Athreya@cavium.com>; Challa, Mahipal
> >> ><Mahipal.Challa@cavium.com>; Sahu, Sunila <Sunila.Sahu@cavium.com>;
> >> >Gupta, Ashish <Ashish.Gupta@cavium.com>
> >> >Subject: RE: [dpdk-dev] [PATCH v4 5/5] doc: add ZLIB PMD guide
> >> >
> >> >External Email
> >> >
> >> >> -----Original Message-----
> >> >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Shally Verma
> >> >> Sent: Monday, July 23, 2018 3:51 PM
> >> >> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> >> >> Cc: dev@dpdk.org; pathreya@caviumnetworks.com;
> >> >> mchalla@caviumnetworks.com; Sunila Sahu
> >> >> <sunila.sahu@caviumnetworks.com>; Ashish Gupta
> >> >> <ashish.gupta@caviumnetworks.com>
> >> >> Subject: [dpdk-dev] [PATCH v4 5/5] doc: add ZLIB PMD guide
> >> >>
> >> >> Add zlib pmd feature support and user guide with build and run
> >> >> instructions
> >> >>
> >> >> Signed-off-by: Sunila Sahu <sunila.sahu@caviumnetworks.com>
> >> >> Signed-off-by: Shally Verma <shally.verma@caviumnetworks.com>
> >> >> Signed-off-by: Ashish Gupta <ashish.gupta@caviumnetworks.com>
> >> >> ---
> >> >>  MAINTAINERS                               |  2 +
> >> >>  doc/guides/compressdevs/features/zlib.ini | 11 +++++
> >> >>  doc/guides/compressdevs/index.rst         |  1 +
> >> >>  doc/guides/compressdevs/zlib.rst          | 69
> >> >> +++++++++++++++++++++++++++++++
> >> >>  4 files changed, 83 insertions(+)
> >> >>
> >> >> diff --git a/MAINTAINERS b/MAINTAINERS index ca27c6f..7e3c450
> >> >> 100644
> >> >> --- a/MAINTAINERS
> >> >> +++ b/MAINTAINERS
> >> >> @@ -875,6 +875,8 @@ F: drivers/common/qat/  ZLIB
> >> >>  M: Sunila Sahu <sunila.sahu@caviumnetworks.com>
> >> >>  F: drivers/compress/zlib/
> >> >> +F: doc/guides/compressdevs/zlib.rst
> >> >> +F: doc/guides/compressdevs/features/zlib.ini
> >> >>
> >> >>  Eventdev Drivers
> >> >>  ----------------
> >> >> diff --git a/doc/guides/compressdevs/features/zlib.ini
> >> >> b/doc/guides/compressdevs/features/zlib.ini
> >> >> new file mode 100644
> >> >> index 0000000..c794643
> >> >> --- /dev/null
> >> >> +++ b/doc/guides/compressdevs/features/zlib.ini
> >> >> @@ -0,0 +1,11 @@
> >> >> +;
> >> >> +; Refer to default.ini for the full list of available PMD features.
> >> >> +;
> >> >> +; Supported features of 'ZLIB' compression driver.
> >> >> +;
> >> >> +[Features]
> >> >> +Pass-through   = Y
> >> >> +Deflate        = Y
> >> >> +Fixed          = Y
> >> >> +Dynamic        = Y
> >> >> +OOP SGL In SGL Out  = Y
> >> >
> >> >I assume that you support also "OOP SGL In LB Out" and "OOP LB In
> >> >SGL Out",
> >> right?
> >> yes, but untested thus not claiming.
> >
> >Right, but knowing that a Linear buffer is basically an SGL with just
> >one segment, I think it is safe to say that you support these two other cases.
> >The only reason why we have them is in case, you only support one of them,
> but you don't support SGL in SGL Out).
> >
> >I won't have time to extend the test for those combinations in this
> >release, I hope I can do that in the next one, but as said, I think it is safe to
> claim that this PMD supports all the cases.
> Agree. However I would still wait to test them before claiming support.

Sure, no problem.

Thanks,
Pablo

> 
> Thanks
> Shally
> >
> >>
> >> Thanks
> >> Shally