From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 3851E25D9 for ; Thu, 26 Jul 2018 19:39:09 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Jul 2018 10:39:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,406,1526367600"; d="scan'208";a="219377989" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by orsmga004.jf.intel.com with ESMTP; 26 Jul 2018 10:39:07 -0700 Received: from irsmsx107.ger.corp.intel.com ([169.254.10.193]) by IRSMSX101.ger.corp.intel.com ([169.254.1.185]) with mapi id 14.03.0319.002; Thu, 26 Jul 2018 18:39:06 +0100 From: "De Lara Guarch, Pablo" To: "Nicolau, Radu" , "dev@dpdk.org" CC: "Hunt, David" , "Yao, Lei A" , "Nicolau, Radu" Thread-Topic: [dpdk-dev] [PATCH] examples/l3fw-power: do not exit on power lib init failure Thread-Index: AQHUHp8yeGoylixYQ0qoiqvEsXK+haSh0GAw Date: Thu, 26 Jul 2018 17:39:05 +0000 Message-ID: References: <1531921784-10578-1-git-send-email-radu.nicolau@intel.com> In-Reply-To: <1531921784-10578-1-git-send-email-radu.nicolau@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDU5NzUzNjQtMDgzZS00ZjNlLTg1YjQtOThhN2ExOTEyMGIzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiRmFjNTB0UjRBZEpIbTA3Mk41ZmpsUXRWWkQwekord28zRTVhUjhxUjNFVDFcLzRkUitoZUluQzR4U0Ywemw0Q24ifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] examples/l3fw-power: do not exit on power lib init failure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Jul 2018 17:39:09 -0000 Hi Radu, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Radu Nicolau > Sent: Wednesday, July 18, 2018 2:50 PM > To: dev@dpdk.org > Cc: Hunt, David ; Yao, Lei A ; > Nicolau, Radu > Subject: [dpdk-dev] [PATCH] examples/l3fw-power: do not exit on power lib= init > failure >=20 > Do not exit the application if power library fails to initialize or high = performance > cores configuration cannot be used. I would say this deserves more explanation. It doesn't look correct to me t= o keep log an error that the power library couldn't be initialized and still the sample application = keeps running. Actually, the way init_power_library is coded, it returns the output of the= call of rte_power_init on the last core (ret is overwritten for each core), which looks wrong to me. Thanks, Pablo >=20 > Signed-off-by: Radu Nicolau > ---