From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pablo.de.lara.guarch@intel.com> Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id B2C841B5F1 for <dev@dpdk.org>; Thu, 10 Jan 2019 12:24:35 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jan 2019 03:24:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,461,1539673200"; d="scan'208";a="117032937" Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23]) by orsmga003.jf.intel.com with ESMTP; 10 Jan 2019 03:24:33 -0800 Received: from irsmsx112.ger.corp.intel.com ([169.254.1.84]) by IRSMSX109.ger.corp.intel.com ([169.254.13.133]) with mapi id 14.03.0415.000; Thu, 10 Jan 2019 11:24:32 +0000 From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com> To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>, "Zhang, Roy Fan" <roy.fan.zhang@intel.com>, "dev@dpdk.org" <dev@dpdk.org> CC: "akhil.goyal@nxp.com" <akhil.goyal@nxp.com>, "Trahe, Fiona" <fiona.trahe@intel.com> Thread-Topic: [PATCH v4 01/12] cryptodev: change queue pair configure structure Thread-Index: AQHUqG6NriAYBDF7JUy/8WKhkBDp+qWoM6cggAApPEA= Date: Thu, 10 Jan 2019 11:24:31 +0000 Message-ID: <E115CCD9D858EF4F90C690B0DCB4D89780362034@irsmsx112.ger.corp.intel.com> References: <20181221135550.80745-1-roy.fan.zhang@intel.com> <20190109225609.20590-1-roy.fan.zhang@intel.com> <20190109225609.20590-2-roy.fan.zhang@intel.com> <E115CCD9D858EF4F90C690B0DCB4D89780361E95@irsmsx112.ger.corp.intel.com> In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D89780361E95@irsmsx112.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNGQwN2QwYjUtYmIyMy00MGUyLThkNTItOTBlZTYwMmNiNzRlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiRkJaeDFQekpoXC9BSW5OVUhZWnAyTXhZbVRzN3Q2YUVaK01PbHBhVUtlTGNRYnBrc0RXdElTTElNamlkQWduaVEifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 01/12] cryptodev: change queue pair configure structure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Thu, 10 Jan 2019 11:24:36 -0000 Hi, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of De Lara Guarch, > Pablo > Sent: Thursday, January 10, 2019 9:47 AM > To: Zhang, Roy Fan <roy.fan.zhang@intel.com>; dev@dpdk.org > Cc: akhil.goyal@nxp.com; Trahe, Fiona <fiona.trahe@intel.com> > Subject: Re: [dpdk-dev] [PATCH v4 01/12] cryptodev: change queue pair > configure structure >=20 >=20 >=20 > > -----Original Message----- > > From: Zhang, Roy Fan > > Sent: Wednesday, January 9, 2019 10:56 PM > > To: dev@dpdk.org > > Cc: akhil.goyal@nxp.com; De Lara Guarch, Pablo > > <pablo.de.lara.guarch@intel.com>; Trahe, Fiona <fiona.trahe@intel.com> > > Subject: [PATCH v4 01/12] cryptodev: change queue pair configure > > structure > > > > This patch changes the cryptodev queue pair configure structure to > > enable two mempool passed into cryptodev PMD simutaneously. > > > > Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com> > > Acked-by: Fiona Trahe <fiona.trahe@@intel.com> > > --- >=20 > ... >=20 > > diff --git a/app/test-crypto-perf/main.c b/app/test-crypto-perf/main.c > > index 953e058c9..38a2e429f 100644 >=20 > ... >=20 > > +++ b/doc/guides/prog_guide/cryptodev_lib.rst >=20 > Could you also update the sample code which calls queue_pair_setup? >=20 > > + > > + > > Logical Cores, Memory and Queues Pair Relationships > > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > > diff --git a/doc/guides/rel_notes/release_19_02.rst > > b/doc/guides/rel_notes/release_19_02.rst > > index e3b2055d0..75128f8f2 100644 > > --- a/doc/guides/rel_notes/release_19_02.rst > > +++ b/doc/guides/rel_notes/release_19_02.rst > > @@ -164,6 +164,9 @@ API Changes > > ``rte_pdump_init()`` and enum ``rte_pdump_socktype`` were deprecated > > since 18.05 and are removed in this release. > > > > +* cryptodev: as shown in the the 18.11 deprecation notice, the last > > parameter > > + of ``rte_cryptodev_queue_pair_setup()``, ``session_pool``, is remove= d. > > + >=20 > ABI versioning should be bumped in this document. >=20 >=20 > > > > ABI Changes > > ----------- > > @@ -183,6 +186,10 @@ ABI Changes > > * mbuf: The format of the sched field of ``rte_mbuf`` has been changed > > to include the following fields: ``queue ID``, ``traffic class``, ``= color``. > > > > +* cryptodev: as shown in the the 18.11 deprecation notice, the > > +structure > > + ``rte_cryptodev_qp_conf`` has been added two parameters of > > +symmetric > > session > > + mempool and symmetric session private data mempool. > > + > > > > Shared Library Versions > > ----------------------- > > diff --git a/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c > > b/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c > > index ebdf7c35a..abc7a6d5f 100644 >=20 > ... >=20 > > +++ b/lib/librte_cryptodev/Makefile > > @@ -1,5 +1,5 @@ > > # SPDX-License-Identifier: BSD-3-Clause -# Copyright(c) 2015 Intel > > Corporation > > +# Copyright(c) 2015-2018 Intel Corporation >=20 > Welcome to 2019 :D >=20 > > > > include $(RTE_SDK)/mk/rte.vars.mk > > > > @@ -7,7 +7,7 @@ include $(RTE_SDK)/mk/rte.vars.mk LIB =3D > > librte_cryptodev.a > > > > # library version > > -LIBABIVER :=3D 5 > > +LIBABIVER :=3D 6 >=20 > Version should also be bumped in the meson.build file. >=20 > > > > # build flags > > CFLAGS +=3D -O3 Forgot to say that the deprecation notice sent for the structure and the API changed needs to be removed from deprecation.rst. Apart from that: Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>