From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 2AB731B1FF for ; Wed, 20 Mar 2019 18:44:18 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Mar 2019 10:44:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,249,1549958400"; d="scan'208";a="135738074" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by orsmga003.jf.intel.com with ESMTP; 20 Mar 2019 10:44:16 -0700 Received: from irsmsx112.ger.corp.intel.com ([169.254.1.167]) by IRSMSX104.ger.corp.intel.com ([169.254.5.56]) with mapi id 14.03.0415.000; Wed, 20 Mar 2019 17:44:15 +0000 From: "De Lara Guarch, Pablo" To: "Zhang, Roy Fan" , "dev@dpdk.org" CC: "akhil.goyal@nxp.com" , "Zhang, Roy Fan" , "Trahe, Fiona" Thread-Topic: [dpdk-dev] [PATCH v2] crypto/aesni_mb: support newer version library only Thread-Index: AQHU0prnE8YLJ7rga02mlaBeMa7fuKYU4lUQ Date: Wed, 20 Mar 2019 17:44:15 +0000 Message-ID: References: <20190304114717.18152-1-roy.fan.zhang@intel.com> <20190304145735.25267-1-roy.fan.zhang@intel.com> In-Reply-To: <20190304145735.25267-1-roy.fan.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMWVkZTU5ZDYtODg5MC00ZDUzLThlMWItOWFkMWU2OTc2MWQwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibytCams1SVBNNFwvNVJRajI5MXpOcmVMRnVsQ2t1dWhneUZYc0JpMTBldTZTdmpOazI5XC9QdXNZaWh2NDc4b3lMIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] crypto/aesni_mb: support newer version library only X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Mar 2019 17:44:19 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Fan Zhang > Sent: Monday, March 4, 2019 2:58 PM > To: dev@dpdk.org > Cc: akhil.goyal@nxp.com; Zhang, Roy Fan ; Trahe, > Fiona > Subject: [dpdk-dev] [PATCH v2] crypto/aesni_mb: support newer version > library only >=20 > As stated in 19.02 deprecation notice, this patch updates the > aesni_mb PMD to remove the support of older Intel-ipsec-mb > library version eariler than 0.52. >=20 > Signed-off-by: Fan Zhang > --- >=20 > v2: > - fixed incorrect version in documentation. >=20 > doc/guides/cryptodevs/aesni_mb.rst | 8 +- > doc/guides/rel_notes/deprecation.rst | 3 - > drivers/crypto/aesni_mb/Makefile | 21 +- > drivers/crypto/aesni_mb/aesni_mb_ops.h | 302 ----- > drivers/crypto/aesni_mb/meson.build | 13 +- > drivers/crypto/aesni_mb/rte_aesni_mb_pmd_compat.c | 1313 --------------= ---- > -- > .../crypto/aesni_mb/rte_aesni_mb_pmd_ops_compat.c | 745 ----------- > drivers/crypto/aesni_mb/rte_aesni_mb_pmd_private.h | 37 - > 8 files changed, 16 insertions(+), 2426 deletions(-) > delete mode 100644 drivers/crypto/aesni_mb/aesni_mb_ops.h > delete mode 100644 drivers/crypto/aesni_mb/rte_aesni_mb_pmd_compat.c > delete mode 100644 > drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops_compat.c >=20 > diff --git a/doc/guides/cryptodevs/aesni_mb.rst > b/doc/guides/cryptodevs/aesni_mb.rst > index 47f2ecc2f..66c44e03a 100644 > --- a/doc/guides/cryptodevs/aesni_mb.rst > +++ b/doc/guides/cryptodevs/aesni_mb.rst > @@ -57,10 +57,7 @@ Limitations >=20 > * Chained mbufs are not supported. > * Only in-place is currently supported (destination address is the same = as > source address). > -* RTE_CRYPTO_AEAD_AES_GCM only works properly when the multi-buffer > library is > - 0.51.0 or newer. > -* RTE_CRYPTO_HASH_AES_GMAC is supported by library version v0.51 or > later. > -* RTE_CRYPTO_HASH_SHA* is supported by library version v0.52 or later. > +* Only support Intel multi buffer library version 0.52 or later. >=20 I'd say it is not needed to state this as a limitation. >=20 > Installation > @@ -92,7 +89,8 @@ and the Multi-Buffer library version supported by them: > 17.05 - 17.08 0.45 - 0.48 > 17.11 0.47 - 0.48 > 18.02 0.48 > - 18.05+ 0.49+ > + 18.05 0.49 Change to 18.05 - 19.02 0.49 - 0.52 > + 19.05+ 0.52+ > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >=20 > Apart from this: Acked-by: Pablo de Lara From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id A2648A00E6 for ; Wed, 20 Mar 2019 18:44:21 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B06F21B273; Wed, 20 Mar 2019 18:44:20 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 2AB731B1FF for ; Wed, 20 Mar 2019 18:44:18 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Mar 2019 10:44:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,249,1549958400"; d="scan'208";a="135738074" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by orsmga003.jf.intel.com with ESMTP; 20 Mar 2019 10:44:16 -0700 Received: from irsmsx112.ger.corp.intel.com ([169.254.1.167]) by IRSMSX104.ger.corp.intel.com ([169.254.5.56]) with mapi id 14.03.0415.000; Wed, 20 Mar 2019 17:44:15 +0000 From: "De Lara Guarch, Pablo" To: "Zhang, Roy Fan" , "dev@dpdk.org" CC: "akhil.goyal@nxp.com" , "Zhang, Roy Fan" , "Trahe, Fiona" Thread-Topic: [dpdk-dev] [PATCH v2] crypto/aesni_mb: support newer version library only Thread-Index: AQHU0prnE8YLJ7rga02mlaBeMa7fuKYU4lUQ Date: Wed, 20 Mar 2019 17:44:15 +0000 Message-ID: References: <20190304114717.18152-1-roy.fan.zhang@intel.com> <20190304145735.25267-1-roy.fan.zhang@intel.com> In-Reply-To: <20190304145735.25267-1-roy.fan.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMWVkZTU5ZDYtODg5MC00ZDUzLThlMWItOWFkMWU2OTc2MWQwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibytCams1SVBNNFwvNVJRajI5MXpOcmVMRnVsQ2t1dWhneUZYc0JpMTBldTZTdmpOazI5XC9QdXNZaWh2NDc4b3lMIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] crypto/aesni_mb: support newer version library only X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190320174415.4pLKmmS7AX1GDSna3FcS_WfZsU9HyD963syzIpy96dY@z> > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Fan Zhang > Sent: Monday, March 4, 2019 2:58 PM > To: dev@dpdk.org > Cc: akhil.goyal@nxp.com; Zhang, Roy Fan ; Trahe, > Fiona > Subject: [dpdk-dev] [PATCH v2] crypto/aesni_mb: support newer version > library only >=20 > As stated in 19.02 deprecation notice, this patch updates the > aesni_mb PMD to remove the support of older Intel-ipsec-mb > library version eariler than 0.52. >=20 > Signed-off-by: Fan Zhang > --- >=20 > v2: > - fixed incorrect version in documentation. >=20 > doc/guides/cryptodevs/aesni_mb.rst | 8 +- > doc/guides/rel_notes/deprecation.rst | 3 - > drivers/crypto/aesni_mb/Makefile | 21 +- > drivers/crypto/aesni_mb/aesni_mb_ops.h | 302 ----- > drivers/crypto/aesni_mb/meson.build | 13 +- > drivers/crypto/aesni_mb/rte_aesni_mb_pmd_compat.c | 1313 --------------= ---- > -- > .../crypto/aesni_mb/rte_aesni_mb_pmd_ops_compat.c | 745 ----------- > drivers/crypto/aesni_mb/rte_aesni_mb_pmd_private.h | 37 - > 8 files changed, 16 insertions(+), 2426 deletions(-) > delete mode 100644 drivers/crypto/aesni_mb/aesni_mb_ops.h > delete mode 100644 drivers/crypto/aesni_mb/rte_aesni_mb_pmd_compat.c > delete mode 100644 > drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops_compat.c >=20 > diff --git a/doc/guides/cryptodevs/aesni_mb.rst > b/doc/guides/cryptodevs/aesni_mb.rst > index 47f2ecc2f..66c44e03a 100644 > --- a/doc/guides/cryptodevs/aesni_mb.rst > +++ b/doc/guides/cryptodevs/aesni_mb.rst > @@ -57,10 +57,7 @@ Limitations >=20 > * Chained mbufs are not supported. > * Only in-place is currently supported (destination address is the same = as > source address). > -* RTE_CRYPTO_AEAD_AES_GCM only works properly when the multi-buffer > library is > - 0.51.0 or newer. > -* RTE_CRYPTO_HASH_AES_GMAC is supported by library version v0.51 or > later. > -* RTE_CRYPTO_HASH_SHA* is supported by library version v0.52 or later. > +* Only support Intel multi buffer library version 0.52 or later. >=20 I'd say it is not needed to state this as a limitation. >=20 > Installation > @@ -92,7 +89,8 @@ and the Multi-Buffer library version supported by them: > 17.05 - 17.08 0.45 - 0.48 > 17.11 0.47 - 0.48 > 18.02 0.48 > - 18.05+ 0.49+ > + 18.05 0.49 Change to 18.05 - 19.02 0.49 - 0.52 > + 19.05+ 0.52+ > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >=20 > Apart from this: Acked-by: Pablo de Lara