From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 12720A0487 for ; Wed, 3 Jul 2019 18:14:12 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 963962BC8; Wed, 3 Jul 2019 18:14:09 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id AC1C51BE0 for ; Wed, 3 Jul 2019 18:14:07 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Jul 2019 09:14:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,446,1557212400"; d="scan'208";a="247680250" Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by orsmga001.jf.intel.com with ESMTP; 03 Jul 2019 09:14:05 -0700 Received: from irsmsx112.ger.corp.intel.com ([169.254.1.194]) by IRSMSX151.ger.corp.intel.com ([169.254.4.183]) with mapi id 14.03.0439.000; Wed, 3 Jul 2019 17:14:05 +0100 From: "De Lara Guarch, Pablo" To: "Nowak, DamianX" , "dev@dpdk.org" CC: "akhil.goyal@nxp.com" , "Trahe, Fiona" , "Kusztal, ArkadiuszX" , "Nowak, DamianX" Thread-Topic: [dpdk-dev] [PATCH v3 2/8] cryptodev: add digest encrypted feature flag Thread-Index: AQHVMZDbUhGMgPdxCEWRTXlhFKOspaa5B3mg Date: Wed, 3 Jul 2019 16:14:04 +0000 Message-ID: References: <20190607100608.16212-1-damianx.nowak@intel.com> <20190703111558.11552-1-damianx.nowak@intel.com> <20190703111558.11552-3-damianx.nowak@intel.com> In-Reply-To: <20190703111558.11552-3-damianx.nowak@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzA5YjU5MzUtYzY1Ny00NGQzLTg4Y2UtYTRkZjc2NWU5YThlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiNlR4RWc1bzdiYnZRUTBQeWp3Q3lKRXg3NitrRWMzRXFCUlp5cUhMWFhrdjBUNUpzTCs5ZXFYV1B1M0ZBVFF0OSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 2/8] cryptodev: add digest encrypted feature flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Damian Nowak > Sent: Wednesday, July 3, 2019 12:16 PM > To: dev@dpdk.org > Cc: akhil.goyal@nxp.com; Trahe, Fiona ; Kusztal, > ArkadiuszX ; Nowak, DamianX > > Subject: [dpdk-dev] [PATCH v3 2/8] cryptodev: add digest encrypted featur= e > flag >=20 > Some PMDs can only support digest being > encrypted separately in auth-cipher operations. > Thus it is required to add feature flag in PMD to reflect if it does supp= ort > digest-appended > both: digest generation with encryption and decryption with digest > verification. > This patch also adds information about new feature flag to the release > notes. >=20 > Signed-off-by: Damian Nowak Looks good. Just one comment below: > +++ b/doc/guides/rel_notes/release_19_08.rst > @@ -169,6 +169,9 @@ API Changes > structure (``rte_crypto_cipher_xform``, ``rte_crypto_auth_xform``, and > ``rte_crypto_aead_xform``) have been changed to ``const uint8_t *data`= `. >=20 > +* cryptodev: ``RTE_CRYPTODEV_FF_DIGEST_ENCRYPTED`` feature flag > + has been introduced. I don't think you need to add anything here, as you are extending the featu= re flags, not changing any, so there is no API breakage. Apart from this comment: Acked-by: Pablo de Lara